Improve Lambda packaging #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think of this approach, @kapilt? |
|
Blorg. Drone why u no like? Marking wip ... 😞 |
|
i sanity checked the server (was curious about memory error raised), but it does appear to be specific to this pr. |
|
Rebased, was 35e03a769e6bb876c37c5d0bd8e1152cca99c8e5. |
|
Ready for review, @kapilt ... |
kapilt
reviewed
Feb 28, 2017
c7n/mu.py
Outdated
| f_path = os.path.join(root, f) | ||
| dest_path = os.path.join(arc_prefix, f) | ||
| self.add_file(f_path, dest_path) | ||
| venv_lib_path = os.path.dirname(ipaddress.__file__) |
There was a problem hiding this comment.
this should not be hacked into the middle of an generic function, let's try to localize this to custodian_archive
There was a problem hiding this comment.
Done in 691592f.
Rather than guessing where library dependencies reside, just sniff an actual dependency. Hopefully this provides the greatest portability?
This test manually creates a `PythonPackageArchive`, and thus it benefiteth not from the "aggressive shrinking" of `custodian_archive`. Here we can be even more aggressive.
We want to keep mu decoupled from custodian as much as we can. This commit replaces the virtualenv_dir parameter of PythonPackageArchive with lib_paths, since the former was only used for computing venv_lib_paths anyway. Effectively then we are pushing the responsibility for computing lib_paths up to the caller.
|
looks like this ended up breaking other library users of mu including mailer. |
kapilt
pushed a commit
to kapilt/cloud-custodian
that referenced
this pull request
Mar 2, 2017
kapilt
added a commit
that referenced
this pull request
Mar 2, 2017
|
😞 |
This was referenced Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #193. Rather than guessing where library dependencies reside, just sniff an actual dependency. Hopefully this provides the greatest portability?