Skip to content
This repository

yas/current-snippet-table is gone which auto-complete is using. #311

Closed
redguardtoo opened this Issue · 6 comments

4 participants

chen bin João Távora zhaokai Noam Postavsky
chen bin

Since you changed this API, the auto-complete failed. yasnippet-20120822.52 has this bug. but yasnippet-20120718 is fine. In d42e5a3, you deleted yas/current-snippet-table and added yas/get-snippet-tables. Then in the latest code (42ed181), you rename yas/get-snippet-tables to yas--get-snippet-tables. If you could do some communication to auto-complete author before upgrading yasnippet, it will be really helpful to us.
I mean auto-complete provide perfect UI for yasnippet, for example, a dropdown menu in console window to choose from multiple candidates.

João Távora

In a recent commit (don't have time to check), I introduced an API (previously there was no API). I did provide a pull request for auto-complete which was merged.

Unfortunately and apparently, I messed up somehwere. I agree this is high priority, but don't have time to check now. The fix should be simple, but I have no time to analyse it now, so if you could provide a patch (or pull request), that would be great.

chen bin

some guy told me that auto-complete already updated and is compatible with your current version now. I will wait and see. I will notify you when it's fixed at auto-complete side.

zhaokai

hello, I find the same question. And I find sone useful information besides, hoping to help you.
http://www.kurup.org/blog/2012/10/15/emacs-autocomplete-stumbles-on-yasnippet/

Noam Postavsky
Collaborator

d42e5a3 ... deleted yas/current-snippet-table and added yas/get-snippet-tables

a51adba renamed yas/get-snippet-tables to yas-get-snippet-tables, but did not alias to the old name.
90cd855 renamed yas-get-snippet-tables to yas--get-snippet-tables.

autocomplete is using the yas/get-snippet-tables name: auto-complete-config.el:149

I introduced an API (previously there was no API). I did provide a pull request for auto-complete which was merged.

That's auto-complete/auto-complete#134 I guess. According to that, yas--get-snippet-tables should be backported.

Noam Postavsky
Collaborator

That's auto-complete/auto-complete#134 I guess. According to that, yas--get-snippet-tables should be backported.

Oops, I got confused by whitespace changes, it's using yas-active-keys, which was added by 8a26ab0: auto-complete-config.el:146

Anyway, I'm closing as it appears to be fixed: with latest auto-complete and yasnippet I see snippets in the completion popup of auto-complete.

Noam Postavsky
Collaborator

If you have yasnippet 0.8.0 (from ELPA) you will still get this error, can be solved by

(defalias 'yas/get-snippet-tables 'yas--get-snippet-tables)
(defalias 'yas/table-hash 'yas--table-hash)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.