New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking during lite builds #723

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Projects
None yet
3 participants
@Crunkle
Contributor

Crunkle commented Aug 16, 2018

Add units.c++ and encoding.c++ to allow the linking of kj::ThrowOverflow::operator()() and kj::decodeWideString respectively. The lite build remains a fair amount smaller than heavy build and has been tested as working on Clang and GCC both.

This is needed in order to fix #576 and other undefined symbols with current CMake setups. I am unsure of the scope of lite builds and their exact exclusions but, without these two sources in the build process, the library seems to have major issues linking to a usable state.

@kentonv

This comment has been minimized.

Show comment
Hide comment
@kentonv

kentonv Aug 17, 2018

Member

Thanks!

Looks like @harrishancock is off the hook. :)

Member

kentonv commented Aug 17, 2018

Thanks!

Looks like @harrishancock is off the hook. :)

@kentonv kentonv merged commit 2742d30 into capnproto:master Aug 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@harrishancock

This comment has been minimized.

Show comment
Hide comment
@harrishancock
Member

harrishancock commented Aug 17, 2018

Thanks @Crunkle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment