Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up/fix locking in handleDisembargo #396

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

zenhack
Copy link
Contributor

@zenhack zenhack commented Dec 21, 2022

  • Avoid syncutil.Without
  • Hold c.lk when invoking sendMessage().

The latter requires us to move some of the release()es later, but this is fine.

- Avoid syncutil.Without
- Hold c.lk when invoking sendMessage().

The latter requires us to move some of the release()es later, but this
is fine.
@zenhack
Copy link
Contributor Author

zenhack commented Dec 21, 2022

Failure looks like #348; re-running.

@zenhack
Copy link
Contributor Author

zenhack commented Dec 21, 2022

#377, let's try again

@zenhack
Copy link
Contributor Author

zenhack commented Dec 21, 2022

#394

@zenhack
Copy link
Contributor Author

zenhack commented Dec 21, 2022

#377 again. @lthibault do you have a strong objection to just merging this?

@lthibault
Copy link
Collaborator

SGTM. Send it :)

@zenhack zenhack merged commit 34de47d into capnproto:main Dec 22, 2022
@zenhack zenhack deleted the handleDisembargo-locking branch December 22, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants