Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handleBootstrap: avoid a use of syncutil.Without() #397

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

zenhack
Copy link
Contributor

@zenhack zenhack commented Dec 21, 2022

Stacked on top of #396; merge that first.

Should be no functional change here.

Only 2 more call sites!

- Avoid syncutil.Without
- Hold c.lk when invoking sendMessage().

The latter requires us to move some of the release()es later, but this
is fine.
@lthibault
Copy link
Collaborator

--- FAIL: TestSendDisembargo (0.01s)
    --- FAIL: TestSendDisembargo/SendQueuedResultToCaller (0.01s)
Error:         level1_test.go:285: Received finish message; want disembargo
Error:         level0_test.go:2124: conn error: rpc: send release: send message: context canceled

Seems like this might be fixed by #396 ?

@zenhack zenhack merged commit ebd690c into capnproto:main Dec 22, 2022
@zenhack zenhack deleted the without-handleBootstrap branch December 22, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants