Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPFlashView - calling setParameters after setFlashVars overwrites FlashVars #1032

Closed
jlujan opened this issue Dec 15, 2010 · 1 comment
Closed

CPFlashView - calling setParameters after setFlashVars overwrites FlashVars #1032

jlujan opened this issue Dec 15, 2010 · 1 comment

Comments

@jlujan
Copy link

jlujan commented Dec 15, 2010

setParameters does not check for _params already being set by setFlashVars. If setFlashVars is called before setParameters, the flashvars will be lost.

Fix in fork here:
jlujan@41d757e

@to-review @working-on
aljungberg added a commit that referenced this issue May 15, 2011
@aljungberg
Merge pull request #1033 from jlujan/cappuccino
868201b 
---

The expression in the while loop in setParameters results in the wrong value being assigned to "key" which results in malformed param tags that look like the following:

    <param name=​"[object HTMLObjectElement]" >

Also, _params is not checked before assignment in setParameters which will overwrite flashvars if setFlashVars was called before setParameters.

Addresses issues #1031 and #1032
@aljungberg
Copy link
Member

Closed by pull request #1033.

@jlujan jlujan mentioned this issue May 15, 2011
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aljungberg @jlujan