CPPasteboard availableTypeFromArray #1683

Closed
BlairDuncan opened this Issue Oct 12, 2012 · 6 comments

Comments

Projects
None yet
5 participants
Contributor

BlairDuncan commented Oct 12, 2012

It returns incorrect results as it is backwards...
currently it is:

  • (CPString)availableTypeFromArray:(CPArray)anArray
    {
    return [[self types] firstObjectCommonWithArray:anArray];
    }
    which returns the first object in [self types] that is common with the provided array.

it should be

  • (CPString)availableTypeFromArray:(CPArray)anArray
    {
    return [anArray firstObjectCommonWithArray:[self types]];
    }
    which returns the first item in the provided array that is in [self types].

cappbot commented Oct 12, 2012

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

Owner

aljungberg commented Oct 12, 2012

+#needs-test

Contributor

ahankinson commented Feb 16, 2013

This does not seem to have been implemented, but it probably needs a core dev to look at it to see if this is the correct behaviour.

-#new
+#acknowledged
+#needs-review

cappbot commented Feb 16, 2013

Milestone: Someday. Labels: #acknowledged, #needs-review. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

BlairDuncan added a commit to BlairDuncan/cappuccino that referenced this issue Feb 17, 2013

aparajita added a commit that referenced this issue Feb 19, 2013

Merge pull request #1773 from BlairDuncan/CPPasteboardAvailableTypesF…
…romArrayFix

CPPasteboard availableTypeFromArray fix issue #1683
Contributor

aparajita commented Feb 19, 2013

Fixed in #1773

#fixed

cappbot commented Feb 20, 2013

Milestone: Someday. Label: #fixed. What's next? This issue is considered successfully resolved.

@cappbot cappbot closed this Feb 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment