CPToolbar calls incorrect CPNotificationCenter removeObserver:object: method #1685

Closed
schipmolder opened this Issue Nov 5, 2012 · 3 comments

Comments

Projects
None yet
4 participants

CPToolbar's _setWindow: method seems to call the non-existing CPNotificationCenter removeObserver:object: method which then throws an exception.

if (_window)
    [[CPNotificationCenter defaultCenter] removeObserver:self object:_window];

If I'm not mistaking this should fix it though:

if (_window)
    [[CPNotificationCenter defaultCenter] removeObserver:self name:nil object:_window];

@schipmolder schipmolder pushed a commit to schipmolder/cappuccino that referenced this issue Nov 5, 2012

Arjen Schipmolder Proposed fix for #1685 b32e989

cappbot commented Nov 5, 2012

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

Contributor

ahankinson commented Feb 12, 2013

I've confirmed that [CPToolbar _setWindow] does indeed call a the non-existent method removeObserver:object on CPNotificationCenter and should be fixed to call removeObserver:name:object.

@schipmolder could you send a pull request with your fix? Thanks.

+#accepted
+bug
+AppKit
milestone=0.9.7

cappbot commented Feb 12, 2013

Milestone: 0.9.7. Labels: #accepted, AppKit, bug. What's next? A reviewer should examine this issue.

aparajita closed this in e40138c Feb 24, 2013

@aparajita aparajita added a commit that referenced this issue Feb 24, 2013

@aparajita aparajita Merge pull request #1796 from ahankinson/fix-issue1685
Fixes #1685: CPToolbar calls incorrect notification method
2c10671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment