Windows larger than the browser window open underneath the main menubar #1690

Closed
BlairDuncan opened this Issue Nov 20, 2012 · 18 comments

Comments

Projects
None yet
5 participants
Contributor

BlairDuncan commented Nov 20, 2012

Can be replicated in Tests/Manual/CPDocumentControllerTest/withNib.
Add the following method to Document.j to override the default startup window postion.

- (void)windowControllerDidLoadCib:(CPWindowController)aWindowController
{
    [[aWindowController window] center];
}

Run the app with the browser window smaller than the document window.
You will see that the document opens below the menu bar rendering it inaccessible.

You'll also notice that the title of the document appears in the menubar. I've never seen a cocoa app with document title in the main menubar.

cappbot commented Nov 20, 2012

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

Contributor

ahankinson commented Feb 18, 2013

I've confirmed two related issues:

  1. The document title bar appears under the main menu, making it impossible to select and drag the window
  2. The document title appears in the menu bar (very strange and definitely non-Cocoa), with the additional bug that if the width of the window is too small the title will appear underneath the menu items, making both unreadable.

-#new
+bug
+AppKit
+#needs-review
milestone=0.9.7

cappbot commented Feb 18, 2013

Milestone: 0.9.7. Labels: #needs-review, AppKit, bug. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

Contributor

aparajita commented Feb 18, 2013

-#needs-review
+#accepted

cappbot commented Feb 18, 2013

Milestone: 0.9.7. Labels: #accepted, AppKit, bug. What's next? A reviewer should examine this issue.

@aparajita aparajita closed this in bbfaac5 Mar 12, 2013

Contributor

aparajita commented Mar 12, 2013

#fixed

cappbot commented Mar 12, 2013

Milestone: 0.9.7. Labels: #fixed, AppKit, bug. What's next? This issue is considered successfully resolved.

Contributor

BlairDuncan commented Mar 12, 2013

can't really tell if its fixed or not, but our menus are definately messed up....
Screen shot 2013-03-12 at 2 09 38 PM
Screen shot 2013-03-12 at 2 10 54 PM

Contributor

aparajita commented Mar 12, 2013

D'oh! I forgot that the menu bar is a window. Okay, I'll fix it.

Contributor

aparajita commented Mar 12, 2013

Fixed.

Contributor

BlairDuncan commented Mar 12, 2013

One more thing, there is now no longer a black line in the document between the document window header and the content view. It just shows up as two small ticks on the left and right. You can see them in the screen cap above just below the w in NewApplication.

Contributor

aparajita commented Mar 12, 2013

This is so bizarre. I did a jake clobber and now a ton of code is broken that worked before. Sigh...

Contributor

stewa commented Mar 12, 2013

The first of these to commits seems to have screwed up attached sheets. Look at Test/Manual/AttachedSheet2
They appear a bit below the window title.

Contributor

stewa commented Mar 12, 2013

And they don't seem to animate, but maybe that's related to other commits.

Contributor

aparajita commented Mar 12, 2013

I know about it, a fix is on the way.

Contributor

aparajita commented Mar 13, 2013

Fixed via 54bc851.

Contributor

BlairDuncan commented Mar 13, 2013

That just leaves the title that appears in the middle of the document. You can see it in the first screencap between the Format and View menus.
@aparajita My fix for that is this, I think we can remove it from CPWindow, comments?

@implementation CPWindow (noTitleInMenuBar)

- (void)_synchronizeMenuBarTitleWithWindowTitle
{
}

@end
Contributor

aparajita commented Mar 13, 2013

Yeah, I don't know what that is doing there. I have never seen a document's title in my menu bar in Cocoa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment