Compiling with -O failed to compress file (silently) #567

Closed
emaillard opened this Issue Mar 22, 2010 · 7 comments

Projects

None yet

6 participants

@emaillard

When i try to build AppKit framework in my tree in Release mode with -O the failed to compress.
Preprocessing seems all good, but compress return an empty string without logging any error.
There's a syntax error in the file that Rhino and Firefox dislike (Safari doesn't complains).
But Jake should log an error, when shrinksafe raise an exception.

@boucher
Member
boucher commented Mar 22, 2010

I don't understand this ticket: is the issue that there's a problem in AppKit, or is the issue that you had your own bug and Shrinksafe didn't tell you about an exception.

@emaillard

The problem is that compress step failed silently (when Shrinksafe raise an exception).
There's no error log by compiler.js, like it does when preprocessor failed.
In my case ObjectiveJ.preprocess didn't have problem with the syntax (a comma instead of a semicolon) but compress raise an exception, and compiler.js didn't log any error in this case.

@nigelgoodship

I've just been caught by exactly this issue, and would certainly like to add my vote for Jake logging an error. My syntax error was the same, a line ending in a comma instead of a semicolon. It would also be helpful if ObjectiveJ.preprocess could raise an exception when this syntax error is encountered, so that a Debug build fails when this syntax error is present.

@aparajita
Collaborator

It would certainly help if we had some sample code that demonstrates the problem.

@cappbot
Collaborator
cappbot commented May 9, 2012

Milestone: Someday. Labels: #needs-patch, #needs-reduction, bug, tools. What's next?

  • This issue needs a volunteer to write and submit code to address it.
  • A minimal test app should be created which demonstrates the concern of this issue in isolation.
@ahankinson

I changed a semicolon to a comma in a sample application and jake release fails with an error now.

+#fixed
milestone=0.9.7

@cappbot
Collaborator
cappbot commented Feb 22, 2013

Milestone: 0.9.7. Labels: #fixed, bug, tools. What's next? This issue is considered successfully resolved.

@cappbot cappbot closed this Feb 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment