GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
CPTableView asks the delegate before it starts tracking
(tableView:shouldTrackView:forTableColumn:row:), also implemented
clickedColumn & clickedRow.
Improved [CPTableView startTrackingAt:], also made [clickedColumn] &
Milestone: Someday. Labels: #needs-reduction, AppKit, feature. What's next? A minimal test app should be created which demonstrates the concern of this issue in isolation.
clickedColumn and clickedRow have been implemented.
I think this needs a design decision on whether the delegate method should be called. If so, I think I can extract it from the patches and create a PR (with tests).
There is no delegate method for a click. If selection is allowed, the click will change the selection and that triggers the delegate method. If no selection is allowed, the assumption is the user doesn't care. If they do care, they have to subclass. Let's not start adding delegate methods without an extremely compelling reason.
Well, the delegate method tableView:shouldTrackView:forTableColumn:row already exists. (In Cocoa, it's tableView:shouldTrackCell...). It's more a question of whether it should be called when the user clicks at a point, which is when I think the startTrackingAt:(CGPoint)aPoint method is called.
As far as I can tell, the setDelegate method will check to see if the delegate responds to this method, but it never actually calls it.
I did not know about that method. We could support it, but given that in Cocoa that method is only supported for cell-based tables, and we are encouraging people to use view-based tables if they have controls in the cells, it seems to me it isn't a priority. (And no one has asked for it yet.)
Ok. I'm going to close this one since cells with controls are view-based.
Milestone: Someday. Labels: #wont-fix, AppKit, feature. What's next? A reviewer or core team member has decided against acting upon this issue.