Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bug: CPButton does not accept first responder #742

Closed
klaaspieter opened this Issue · 12 comments

6 participants

@klaaspieter

CPButton should accept first responder state so it can be selected using the keyboard. A button that is first responder should performClick: when the space key is pressed

Fix is on a clean branch here.

Currently the state of the button is not yet visible because focus rings are not yet implemented.

@boucher
Collaborator

Right now, taking this in would also make it so that tabbing would stop on CPButtons in addition to CPTextFields. In Cocoa this doesn't happen unless you turn on a specific setting. Perhaps this is a separate issue and code dealing with key view loops needs to be made more advanced. Thoughts?

@klaaspieter

Yeah, I noticed that later as well. I have the setting in Cocoa turned on, so my behavior is that it tabbing also makes buttons first responder.

The default setting in Mac OS X is off. I think tabbing through All Controls is meant for advanced users or users with accessibility problems.

Meaning that if we make the default in Cappuccino on, we automatically get some accessibility with it. Turning it off would mean less accessibility, but easier to understand for regular users.

To be honest, I don't know which one is the best. Maybe this warrants a bigger discussion on the mailing list?

@cappbot
Collaborator

Label: #new. What's next? A reviewer should examine this issue.

@ahankinson

I think this has probably been fixed, but I need confirmation. If not, I think it is a big enough bug to punt to 0.9.7.

-#new
+#needs-confirmation
milestone=0.9.7

@cappbot
Collaborator

Milestone: 0.9.7. Label: #needs-confirmation. What's next? This issue needs a volunteer to independently reproduce the issue.

@ahankinson

I think this one just needs a yes/no decision: Should CPButtons accept first responder status?

"YES" would mimic the functionality of enabling the accessibility controls; "NO" would mimic default OSX behaviour.

For what it's worth, my vote would be for YES.

@aljungberg
Owner

Full accessibility mode should be a mode, not a default. I believe the reason OS X does not enable it by default is because it allows quick navigation of the important fields - the text fields - without getting caught up in buttons.

If you want to work on this, this pull request actually implements it as a flag: #1697.

@ahankinson

Hm. It looks like this one might be a bit more than 0.9.7... I'll change it to 1.0

milestone=1.0

@cappbot
Collaborator

Milestone: 1.0. Label: #needs-confirmation. What's next? This issue needs a volunteer to independently reproduce the issue.

@daboe01

i am closing this one based on alexanders statement from the list
https://groups.google.com/forum/#!searchin/objectivej/button$20keyboard/objectivej/oxcD6HH_Uds/NMtyReHqrPcJ
+#wont-fix

@cappbot
Collaborator

Milestone: 1.0. Label: #wont-fix. What's next? A reviewer or core team member has decided against acting upon this issue.

@cappbot cappbot closed this
@cappbot
Collaborator

Milestone: 1.0. Label: #wont-fix. What's next? A reviewer or core team member has decided against acting upon this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.