New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Aristo Art for CPPopUpButton and CPTextField #1046

Merged
13 commits merged into from Dec 20, 2010

Conversation

Projects
None yet
5 participants
@primalmotion
Member

primalmotion commented Dec 17, 2010

A screenshot can be viewed here http://gyazo.com/fe08eb3b0a89ab4d88aad7f4e5f1ac8f

@cncolder

This comment has been minimized.

Show comment
Hide comment
@cncolder

cncolder Dec 18, 2010

Contributor

Wow! Thanks for our artist — primalmotion. lol.
I hope you can makeup CPBox together.

Contributor

cncolder commented Dec 18, 2010

Wow! Thanks for our artist — primalmotion. lol.
I hope you can makeup CPBox together.

@primalmotion

This comment has been minimized.

Show comment
Hide comment
@primalmotion

primalmotion Dec 20, 2010

Member

The art is not mine, it's from Sofa :)

Member

primalmotion commented Dec 20, 2010

The art is not mine, it's from Sofa :)

@aljungberg

This comment has been minimized.

Show comment
Hide comment
@aljungberg

aljungberg Dec 20, 2010

Member

This commit looks like it's trying to revert 0867ccd. Why?

Member

aljungberg commented on f936277 Dec 20, 2010

This commit looks like it's trying to revert 0867ccd. Why?

This comment has been minimized.

Show comment
Hide comment
@primalmotion

primalmotion Dec 20, 2010

Member

Ah yeah exact. But if we keep the 18px height the tokens are not vertically centered with new CPTextField Art.

Member

primalmotion replied Dec 20, 2010

Ah yeah exact. But if we keep the 18px height the tokens are not vertically centered with new CPTextField Art.

This comment has been minimized.

Show comment
Hide comment
@boucher

boucher Dec 20, 2010

Member

Can we get a before/after photo?

Member

boucher replied Dec 20, 2010

Can we get a before/after photo?

This comment has been minimized.

Show comment
Hide comment
@primalmotion

This comment has been minimized.

Show comment
Hide comment
@primalmotion

primalmotion Dec 24, 2010

Member

as an answer to cncolder that said (And I don't know why I can't see this message here..)

I'm not sure if this commit make text field bezel display incorrect.
Test page:
http://cncolder.github.com/cappuccino/pages/cptextfield-bezel
Source code:
https://github.com/cncolder/cappuccino/tree/gh-pages/pages/cptextfield-bezel

View Issue: https://github.com/280north/cappuccino/pull/1046#issuecomment-633430

You need to jake clean your Cappuccino copy in order to regenerate the theme with new artwork.

Member

primalmotion commented Dec 24, 2010

as an answer to cncolder that said (And I don't know why I can't see this message here..)

I'm not sure if this commit make text field bezel display incorrect.
Test page:
http://cncolder.github.com/cappuccino/pages/cptextfield-bezel
Source code:
https://github.com/cncolder/cappuccino/tree/gh-pages/pages/cptextfield-bezel

View Issue: https://github.com/280north/cappuccino/pull/1046#issuecomment-633430

You need to jake clean your Cappuccino copy in order to regenerate the theme with new artwork.

@cncolder

This comment has been minimized.

Show comment
Hide comment
@cncolder

cncolder Dec 24, 2010

Contributor

Sorry, my bad.
You are right and I have make this mistake twice.
I have delete that comment my self.

Contributor

cncolder commented Dec 24, 2010

Sorry, my bad.
You are right and I have make this mistake twice.
I have delete that comment my self.

@cappbot cappbot added this to the Someday milestone Sep 29, 2015

@cappbot cappbot added the #new label Sep 29, 2015

@cappbot

This comment has been minimized.

Show comment
Hide comment
@cappbot

cappbot Sep 29, 2015

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

cappbot commented Sep 29, 2015

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment