Compilation problems on ubuntu #1405

Merged
merged 2 commits into from Jan 3, 2012

Conversation

Projects
None yet
4 participants
Contributor

neerfri commented Nov 27, 2011

This fixes two issues in compiling on linux (ubuntu):1. parameters to gcc should be joined with " "2. the -DENVIRONMENTS parameter needs OS.enquote otherwise the linux shell removes the quotes

Owner

primalmotion commented Nov 28, 2011

what are the original issues this patch should fix in term of error messages?

Contributor

neerfri commented Nov 30, 2011

The first one resolves "TypeError: framework is not a function, it is undefined." when compiling Objective-J
The second one resolves "Error: Could not load file at Foundation/Foundation.j" when compiling Aristo theme

Owner

primalmotion commented Jan 3, 2012

I have no Ubuntu to try it out, but I tried both on Mac OS X with rhino and on Fedora, and it works as expected.
I let the builds to terminate to be sure and I'll merge it.

primalmotion pushed a commit that referenced this pull request Jan 3, 2012

Merge pull request #1405 from applicaster/linux_rhino
Compilation problems on ubuntu

@primalmotion primalmotion merged commit 47a5296 into cappuccino:master Jan 3, 2012

Owner

primalmotion commented Jan 3, 2012

Thanks. Any input from another Ubuntu user would be welcome.

Contributor

james-dessart-hb commented Jan 11, 2012

I was able to build on Ubuntu 11.10 after these changes were made.

cappbot commented Sep 29, 2015

Label: #needs-review. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment