Enable additional buttonTypes for CPButton #1438

Merged
merged 5 commits into from Feb 1, 2012

Conversation

Projects
None yet
5 participants
Contributor

thewalkingtoast commented Jan 25, 2012

This corrects issue #1427 by enabling CPButton to correctly handle different buttonTypes.

AppKit/CPButton.j
- [self invalidateTimers];
-
- [super stopTracking:lastPoint at:aPoint mouseIsUp:mouseIsUp];
+ [self invalidateTimers];
@boucher

boucher Jan 25, 2012

Member

Minor whitespace bug here.

AppKit/CPButton.j
+ else
+ _displayTitle = [self title];
+
+ if (_highlightsBy === CPMomentaryChangeButton)
@boucher

boucher Jan 25, 2012

Member

Another minor whitespace bug

Contributor

Me1000 commented Jan 26, 2012

One final request, what would be super helpful for is if you could make a sample app in Tests/ManualTests/ showing a series of buttons with various button types, also showing what happens when you change the type of a single buttons or something... basically, manual test cases. :)

Contributor

thewalkingtoast commented Jan 26, 2012

I want to add it to the current CPButton manual test ( the test is for images and continuous ), but XcodeCapp is having a hard time processing the xib. It works okay for a few edits but then the test starts displaying an empty window. It will immediately display this "empty window" (blank white browser screen) after I attempt to add a new NSWindow. Any clues?

Contributor

Me1000 commented Feb 1, 2012

Awesome, thanks so much! Merged!

Me1000 added a commit that referenced this pull request Feb 1, 2012

Merge pull request #1438 from aradabaugh/master
Enable additional buttonTypes for CPButton

@Me1000 Me1000 merged commit e081dbf into cappuccino:master Feb 1, 2012

Contributor

cacaodev commented Feb 7, 2012

After this commit, popup buttons don't reflect the selection anymore.

See https://groups.google.com/forum/?pli=1#!topic/objectivej/eM3imHYDxeo

Contributor

thewalkingtoast commented Feb 7, 2012

I will look into it. Thanks!

aparajita added a commit that referenced this pull request Feb 16, 2012

Revert "Merge pull request #1438 from aradabaugh/master", it broke a …
…few things

This reverts commit e081dbf, reversing
changes made to 71e8f02.

@cappbot cappbot added this to the Someday milestone Sep 29, 2015

@cappbot cappbot added the #new label Sep 29, 2015

cappbot commented Sep 29, 2015

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment