CPURLConnection -sendSynchronousRequest: return nil on failure. #1636

Merged
merged 2 commits into from Feb 19, 2013

Conversation

Projects
None yet
4 participants
@cacaodev
Contributor

cacaodev commented Jul 27, 2012

Return nil if CPHTTPRequest failed.

Do we need a test for that ?

@cappbot

This comment has been minimized.

Show comment Hide comment
@cappbot

cappbot Jul 27, 2012

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

cappbot commented Jul 27, 2012

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@aparajita

This comment has been minimized.

Show comment Hide comment
@aparajita

aparajita Jul 27, 2012

Contributor

A test would be nice.

Contributor

aparajita commented Jul 27, 2012

A test would be nice.

@ahankinson

This comment has been minimized.

Show comment Hide comment
@ahankinson

ahankinson Feb 16, 2013

Contributor

This needs review. #1637 claims that it is dependent on this one, but that one was merged and this one was not. The changes that this patch makes have not been merged in.

-#new
+#needs-review
+Foundation

Contributor

ahankinson commented Feb 16, 2013

This needs review. #1637 claims that it is dependent on this one, but that one was merged and this one was not. The changes that this patch makes have not been merged in.

-#new
+#needs-review
+Foundation

@cappbot

This comment has been minimized.

Show comment Hide comment
@cappbot

cappbot Feb 16, 2013

Milestone: Someday. Labels: #needs-review, Foundation. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

cappbot commented Feb 16, 2013

Milestone: Someday. Labels: #needs-review, Foundation. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

@aparajita aparajita merged commit 7ecf6ec into cappuccino:master Feb 19, 2013

@aparajita

This comment has been minimized.

Show comment Hide comment
@aparajita

aparajita Feb 19, 2013

Contributor

Merged, merci!

#fixed

Contributor

aparajita commented Feb 19, 2013

Merged, merci!

#fixed

@cappbot

This comment has been minimized.

Show comment Hide comment
@cappbot

cappbot Feb 19, 2013

Milestone: Someday. Labels: #fixed, Foundation. What's next? This issue is considered successfully resolved.

cappbot commented Feb 19, 2013

Milestone: Someday. Labels: #fixed, Foundation. What's next? This issue is considered successfully resolved.

@cacaodev cacaodev deleted the cacaodev:CPURLConnection-sendSynchronousRequest branch Feb 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment