nib2cib allows CPCheckBox and CPRadio to have themed height #1694

Merged
merged 1 commit into from Feb 16, 2013

5 participants

@mrcarlberg
Cappuccino member

and adjusts it correctly.

@cappbot

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@ahankinson

I've verified that this PR merges, builds, tests, and is ready to commit.

+#accepted
+#ready-to-commit

@cappbot

Milestone: Someday. Labels: #accepted, #ready-to-commit. What's next? The changes for this issue are ready to be committed by a member of the core team.

@aparajita

Do we have a test case to show before and after?

@primalmotion primalmotion was assigned Feb 11, 2013
@aparajita

assigned=primalmotion

Antoine should be the one to look at this.

@cappbot

Assignee: primalmotion. Milestone: Someday. Labels: #accepted, #ready-to-commit. What's next? The changes for this issue are ready to be committed by primalmotion.

@primalmotion
Cappuccino member

It seems good.

+#ready-to-commit

@primalmotion primalmotion merged commit 6673823 into cappuccino:master Feb 16, 2013
@primalmotion
Cappuccino member

Merged. Thanks!

+#fixed

@cappbot

Assignee: primalmotion. Milestone: Someday. Label: #fixed. What's next? This issue is considered successfully resolved.

@cappbot

Assignee: primalmotion. Milestone: Someday. Labels: #accepted, #ready-to-commit. What's next? The changes for this issue are ready to be committed by primalmotion.

@cappbot

Assignee: primalmotion. Milestone: Someday. Label: #fixed. What's next? This issue is considered successfully resolved.

@mrcarlberg mrcarlberg deleted the mrcarlberg:nib2cib_allow_themed_height_on_checkbox_and_radio branch Feb 5, 2016
@cappbot

Milestone: Someday. Label: #fixed. What's next? This issue is considered successfully resolved.

@cappbot

Assignee: primalmotion. Milestone: Someday. Label: #fixed. What's next? This issue is considered successfully resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment