Fixed CPDocumentController missing method currentDocument #1870

Merged
merged 2 commits into from Jun 12, 2013

Conversation

Projects
None yet
4 participants
Contributor

BlairDuncan commented Mar 21, 2013

In this commit I've added the currentDocument method to the document controller

Also removed the firstEligibleExistingWindowController method from CPDocument
It did nothing but add confusion as it was not used anywhere else in the frameworks.
And it is not in cocoa.

@BlairDuncan BlairDuncan Fixed CPDocumentController missing method currentDocument
In this commit I've added the currentDocument method to the document controller

Also removed the firstEligibleExistingWindowController method from CPDocument
It did nothing but add confusion as it was not used anywhere else in the frameworks.
And it is not in cocoa.
3178f0b

cappbot commented Mar 21, 2013

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@BlairDuncan BlairDuncan added missing methods to CPDocumentController
documentForWindow
hasEditedDocuments

both are in cocoa
5868a4c
Contributor

ahankinson commented Mar 21, 2013

-#new
+feature
+AppKit
+#needs-review

cappbot commented Mar 21, 2013

Milestone: Someday. Labels: #needs-review, AppKit, feature. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

Contributor

ahankinson commented Jun 3, 2013

-#needs-review
+#ready-to-commit

cappbot commented Jun 3, 2013

Milestone: Someday. Labels: #ready-to-commit, AppKit, feature. What's next? The changes for this issue are ready to be committed by a member of the core team.

@aljungberg aljungberg added a commit that referenced this pull request Jun 12, 2013

@aljungberg aljungberg Merge pull request #1870 from BlairDuncan/documentControllerCurrentDo…
…cument

Fixed CPDocumentController missing method currentDocument
6ab6503

@aljungberg aljungberg added a commit that referenced this pull request Jun 12, 2013

@aljungberg aljungberg Formatting: whitespace.
Refs #1870.
e2339ee

@aljungberg aljungberg added a commit that referenced this pull request Jun 12, 2013

@aljungberg aljungberg Fixed: remove non-standard CPDocument API "firstEligibleExistingWindo…
…wController".

This method did not actually do anything, and was not part of the expected CPDocument API.

Refs #1870.
22dcacd

@aljungberg aljungberg merged commit 5868a4c into cappuccino:master Jun 12, 2013

1 check passed

default The Travis build passed
Details
Owner

aljungberg commented Jun 12, 2013

Merged. Thanks!

milestone=0.9.7
assignee=aljungberg
+#fixed

aljungberg was assigned Jun 12, 2013

cappbot commented Jun 12, 2013

Assignee: aljungberg. Milestone: 0.9.7. Labels: #fixed, AppKit, feature. What's next? This issue is considered successfully resolved.

cappbot commented May 6, 2016

Milestone: 0.9.7. Labels: #fixed, AppKit, feature. What's next? This issue is considered successfully resolved.

cappbot commented May 6, 2016

Assignee: aljungberg. Milestone: 0.9.7. Labels: #fixed, AppKit, feature. What's next? This issue is considered successfully resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment