Fixed: XCodeCapp adding duplicate files to Xcode project #1873

Merged
merged 1 commit into from Apr 5, 2013

Conversation

Projects
None yet
3 participants
Contributor

ahankinson commented Mar 22, 2013

Previously, XCC would indiscriminately add files to the Xcode project via the pbxprojModifier.py script. This resulted in duplicate references to a file.

This fix adds a check to see if the file is already included in the project's sourceGroup folder, and will return None if it is.

Fixes #1866

@ahankinson ahankinson Fixed: XCodeCapp adding duplicate files to Xcode project
Previously, XCC would indiscriminately add files to the Xcode project via the pbxprojModifier.py script. This resulted in duplicate references to a file.

This fix adds a check to see if the file is already included in the project's sourceGroup folder, and will return None if it is.

Fixes #1866
5c3adfd
Contributor

ahankinson commented Mar 23, 2013

-#new
+bug
+Tools
+#needs-review

cappbot commented Mar 24, 2013

Milestone: Someday. Labels: #needs-review, bug, tools. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

@primalmotion primalmotion added a commit that referenced this pull request Apr 5, 2013

@primalmotion primalmotion Merge pull request #1873 from ahankinson/fix-issue1866
Fixed: XCodeCapp adding duplicate files to Xcode project
70081e1

@primalmotion primalmotion merged commit 70081e1 into cappuccino:master Apr 5, 2013

1 check passed

default The Travis build passed
Details
Owner

primalmotion commented Apr 5, 2013

Merged Thanks!

+#fixed

ahankinson deleted the ahankinson:fix-issue1866 branch Apr 8, 2013

cappbot commented Apr 8, 2013

Milestone: Someday. Labels: #fixed, bug, tools. What's next? This issue is considered successfully resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment