Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Added themable attribute for divider thickness in table header view #1970

Merged

Conversation

mrcarlberg
Copy link
Member

No description provided.

@cappbot
Copy link

cappbot commented Aug 6, 2013

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@ahankinson
Copy link
Contributor

-#new
+feature
+AppKit
+#needs-improvement

@ahankinson
Copy link
Contributor

I think "@divider-thickness" needs to be pre-defined in the theme file. Travis seems to be unhappy about the theme setting:

CPViewTest..
addError test=[CPViewTest testCanFlushPendingLayoutWork]: CPTableHeaderView does not contain theme attribute 'divider-thickness'
Trace not implemented
....
CPSplitViewTest...
addError test=[CPSplitViewTest testAutosave]: CPTableHeaderView does not contain theme attribute 'divider-thickness'
Trace not implemented

@cappbot
Copy link

cappbot commented Aug 10, 2013

Milestone: Someday. Labels: #needs-improvement, AppKit, feature. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon.

primalmotion added a commit that referenced this pull request Nov 19, 2013
New: Added themable attribute for divider thickness in table header view
@primalmotion primalmotion merged commit 8ca7227 into cappuccino:master Nov 19, 2013
@primalmotion
Copy link
Member

Merged, Thanks!

+#fixed

@cappbot
Copy link

cappbot commented Nov 19, 2013

Milestone: Someday. Labels: #fixed, AppKit, feature. What's next? This issue is considered successfully resolved.

@mrcarlberg mrcarlberg deleted the table_header_divider_thickness branch February 5, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants