Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: network errors had been silently ignored by CPURLConnection #3000

Closed

Conversation

daboe01
Copy link
Contributor

@daboe01 daboe01 commented Aug 25, 2021

@cappbot cappbot added this to the Someday milestone Aug 25, 2021
@cappbot cappbot added the #new label Aug 25, 2021
@cappbot
Copy link

cappbot commented Aug 25, 2021

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@daboe01
Copy link
Contributor Author

daboe01 commented Sep 4, 2021

In commit 09b8db8 i want to verify, whether a delegate method has been triggered by an asynchronous process. how can i test asynchronous behavior using OJTest?

@daboe01
Copy link
Contributor Author

daboe01 commented Sep 8, 2021

-#new
+Foundation
+#needs-review

@cappbot
Copy link

cappbot commented Sep 8, 2021

Milestone: Someday. Labels: #needs-review, Foundation. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

@daboe01
Copy link
Contributor Author

daboe01 commented Jan 4, 2022

@mrcarlberg can the asynchronous unit test be fixed with your latest extensions to the objective-j language?

@mrcarlberg
Copy link
Member

Yes, you can use async test cases with the Node version. Check CPViewControllerTest.j and CPBundleTest.j

@daboe01
Copy link
Contributor Author

daboe01 commented Jan 7, 2022

i had a brief look at this, and unfortunately this seems to depend on refactoring [CPURLConnection connectionWithRequest:delegate:] to return a Promise? Is this correct?

@daboe01
Copy link
Contributor Author

daboe01 commented Jan 7, 2022

@daboe01
Copy link
Contributor Author

daboe01 commented Jan 10, 2022

@mrcarlberg are you ok with removing the automated test from this PR?
it looks like we can only test this in a later cappuccino version with some refactoring of CPConnection.

@cacaodev
Copy link
Contributor

cacaodev commented Mar 5, 2022

This is very helpful but we need to know the browser support before commiting.

@cappbot
Copy link

cappbot commented Mar 16, 2022

Milestone: Someday. Labels: #needs-info, #needs-review, Foundation. What's next?

  • This issue is pending an architectural or implementation design decision and should be discussed or voted on.
  • Additional information should be added as a comment to this isuse.

@daboe01
Copy link
Contributor Author

daboe01 commented Mar 24, 2022

-#needs-review

@cappbot
Copy link

cappbot commented Mar 24, 2022

Milestone: Someday. Labels: #needs-info, Foundation. What's next? Additional information should be added as a comment to this isuse.

@daboe01
Copy link
Contributor Author

daboe01 commented Jun 5, 2022

i will close this one and make a new PR against the node version.
+#wont-fix

@cappbot
Copy link

cappbot commented Jun 5, 2022

Milestone: Someday. Labels: #wont-fix, Foundation. What's next? A reviewer or core team member has decided against acting upon this issue.

@cappbot cappbot closed this Jun 5, 2022
@cappbot
Copy link

cappbot commented Jun 5, 2022

Milestone: Someday. Labels: #wont-fix, Foundation. What's next? A reviewer or core team member has decided against acting upon this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants