fix: [#1308] Fix a bug of multiple fallbacks of custom property#1309
Merged
Conversation
capricorn86
approved these changes
Mar 14, 2024
capricorn86
left a comment
Owner
There was a problem hiding this comment.
Thank you for contributing @odanado! 🌟
matchAll() will execute a find all and return an iterator for each loop in the while statement, which will not have very good performance.
I instead corrected the exec() to run on the modified value, which solved the problem.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1308
The previous code was incorrect in its use of RegExp.prototype.exec, and the regular expression matching was performed only once.
RegExp.prototype.execis difficult to use correctly because it is a stateful API.I modified the logic using String.prototype.matchAll as described in MDN.