From aafdcace6c84e0fa16b011e0fb43ded2ae8fb51b Mon Sep 17 00:00:00 2001 From: kabeor <1597915586@qq.com> Date: Mon, 28 Feb 2022 10:42:44 +0800 Subject: [PATCH 1/3] disable publish to testpypi for now --- .github/workflows/python-publish.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/python-publish.yml b/.github/workflows/python-publish.yml index 0544bc724b..9408b4ae26 100644 --- a/.github/workflows/python-publish.yml +++ b/.github/workflows/python-publish.yml @@ -65,12 +65,12 @@ jobs: name: artifact path: dist - - name: Publish distribution 📦 to test PyPI - uses: pypa/gh-action-pypi-publish@master - with: - user: __token__ - password: ${{ secrets.testpypi_pass }} - repository_url: https://test.pypi.org/legacy/ + # - name: Publish distribution 📦 to test PyPI + # uses: pypa/gh-action-pypi-publish@master + # with: + # user: __token__ + # password: ${{ secrets.testpypi_pass }} + # repository_url: https://test.pypi.org/legacy/ - name: Publish distribution 📦 to PyPI if: ${{ success() }} From bc4e264f4002a101b27083c3d6b8061b03f7657c Mon Sep 17 00:00:00 2001 From: kabeor <1597915586@qq.com> Date: Mon, 28 Feb 2022 13:26:08 +0800 Subject: [PATCH 2/3] fixed incorrect MI->ac_idx leading to wrong AArch64 InsnOp access printing --- arch/AArch64/AArch64InstPrinter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/AArch64/AArch64InstPrinter.c b/arch/AArch64/AArch64InstPrinter.c index 31af0408fd..790f195e73 100644 --- a/arch/AArch64/AArch64InstPrinter.c +++ b/arch/AArch64/AArch64InstPrinter.c @@ -848,6 +848,7 @@ static void printOperand(MCInst *MI, unsigned OpNum, SStream *O) access = get_op_access(MI->csh, MCInst_getOpcode(MI), OpNum); MI->flat_insn->detail->arm64.operands[MI->flat_insn->detail->arm64.op_count].access = access; + MI->ac_idx++; #endif MI->flat_insn->detail->arm64.operands[MI->flat_insn->detail->arm64.op_count].type = ARM64_OP_REG; MI->flat_insn->detail->arm64.operands[MI->flat_insn->detail->arm64.op_count].reg = Reg; From eebd8458209c1a0334382d4469520b7584d4f876 Mon Sep 17 00:00:00 2001 From: kabeor <1597915586@qq.com> Date: Mon, 28 Feb 2022 14:02:57 +0800 Subject: [PATCH 3/3] add ldr operands access issue testcase --- suite/cstest/issues.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/suite/cstest/issues.cs b/suite/cstest/issues.cs index 700a309477..e4fb6cfa63 100644 --- a/suite/cstest/issues.cs +++ b/suite/cstest/issues.cs @@ -1,3 +1,7 @@ +!# issue 1839 AArch64 Incorrect detailed disassembly of ldr +!# CS_ARCH_ARM64, CS_MODE_ARM, CS_OPT_DETAIL +0x41,0x00,0x40,0xf9 == ldr x1, [x2] ; operands[0].access: WRITE ; operands[1].access: READ + // !# issue 1827 x86-16 lcall 0:0xd // !# CS_ARCH_X86, CS_MODE_16, CS_OPT_DETAIL // 0x9a,0x0d,0x00,0x00,0x00 == lcall 0:0xd