Join GitHub today
Marked instruction with std::maker::sync. #23
This is done to make it usable by multiple threads. Capstone claims to be 'Thread-safe by design', so this should work.
Note that there are two flaky tests: They sometimes fail with and without my commit.
I just realised this needs more work:
Do you think I can just edit this?
The Capstone C library may be "thread safe", but that does not mean the
As you noticed, it is unsafe to make
@felberj could you give me more details on your the setup? I'm unable to reproduce this issue.
As is, I can't merge this change. It would be incorrect to mark these structs as
Out of curiousity, what are you trying to do that would require
Thank you for looking into it:
I want to analyse instructions from multiple threads, so this is what I wanted to do. What I will probably do now is copy all the information in my own struct.
If you mean the
If you mean the test errors:
well, I just invoked