-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marked instruction with std::maker::sync. #23
Conversation
This is done to make it usable by multiple threads. Capstone claims to be 'Thread-safe by design', so this should work.
I just realised this needs more work:
Do you think I can just edit this? |
The Capstone C library may be "thread safe", but that does not mean the As you noticed, it is unsafe to make |
@felberj could you give me more details on your the setup? I'm unable to reproduce this issue. Information:
As is, I can't merge this change. It would be incorrect to mark these structs as Out of curiousity, what are you trying to do that would require |
Thank you for looking into it:
I want to analyse instructions from multiple threads, so this is what I wanted to do. What I will probably do now is copy all the information in my own struct.
If you mean the If you mean the test errors:
macOS
x86
well, I just invoked |
@felberj what version of macOS are you running? Also, what's the output of commands:
|
macOS Sierra |
Closing because current pull request does not solve issue. Further discussion should occur in issue #26 |
This is done to make it usable by multiple threads. Capstone claims to be 'Thread-safe by design', so this should work.
Note that there are two flaky tests: They sometimes fail with and without my commit.