Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove lifetime of Capstone, and adjust self mutablity for disasm #49
Discussed in the following post:
This change compiles all tests, but I didn't run the tests, please confirm with your own test before merge.
@@ Coverage Diff @@ ## master #49 +/- ## ========================================== + Coverage 93.85% 94.07% +0.21% ========================================== Files 15 15 Lines 2019 2094 +75 ========================================== + Hits 1895 1970 +75 Misses 124 124
It looks like that
Capstone is also not
UnwindSafe, because it contains
*mut _, this is a good thing as this only prevents you to return a
catch_unwind, and this is the safety garantee that the underline handle can never being called simultaneously.
Oct 5, 2018
I think that remove the
@earthengine thanks for your help!