Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpdk 19.11 updates and deps/build.rs updates #90

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Conversation

zeeshanlakhani
Copy link
Member

@zeeshanlakhani zeeshanlakhani commented Apr 30, 2020

Handles #86 in association with capsule-rs/sandbox#13.

Note: bench-pr job will break (only until merged) here as it's using the new container, which being on 19.11 dpdk, is a breaking change w/ master.

@@ -38,7 +38,7 @@ jobs:
runs-on: ubuntu-18.04

container:
image: getcapsule/sandbox
image: getcapsule/sandbox:19.11.1-1.43
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file's changes only necessary until reviews (docker hub updates) occur.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #90 into master will decrease coverage by 2.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   68.40%   66.39%   -2.02%     
==========================================
  Files          60       60              
  Lines        4621     4621              
==========================================
- Hits         3161     3068      -93     
- Misses       1460     1553      +93     
Impacted Files Coverage Δ
core/src/dpdk/mod.rs 29.50% <0.00%> (ø)
core/src/testils/mod.rs 100.00% <100.00%> (ø)
core/src/packets/icmp/v6/ndp/router_solicit.rs 58.97% <0.00%> (-5.13%) ⬇️
core/src/packets/ethernet.rs 83.57% <0.00%> (-5.00%) ⬇️
core/src/packets/icmp/v4/mod.rs 86.91% <0.00%> (-4.68%) ⬇️
core/src/packets/ip/v4.rs 91.34% <0.00%> (-4.33%) ⬇️
core/src/packets/ip/v6/fragment.rs 75.53% <0.00%> (-4.32%) ⬇️
core/src/packets/icmp/v6/mod.rs 82.78% <0.00%> (-4.10%) ⬇️
core/src/packets/icmp/v6/ndp/neighbor_solicit.rs 68.00% <0.00%> (-4.00%) ⬇️
core/src/packets/udp.rs 89.40% <0.00%> (-3.98%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2830b...93e2a45. Read the comment docs.

Copy link
Contributor

@drunkirishcoder drunkirishcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants