-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpdk 19.11 updates and deps/build.rs updates #90
Conversation
.github/workflows/main.yml
Outdated
@@ -38,7 +38,7 @@ jobs: | |||
runs-on: ubuntu-18.04 | |||
|
|||
container: | |||
image: getcapsule/sandbox | |||
image: getcapsule/sandbox:19.11.1-1.43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file's changes only necessary until reviews (docker hub updates) occur.
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 68.40% 66.39% -2.02%
==========================================
Files 60 60
Lines 4621 4621
==========================================
- Hits 3161 3068 -93
- Misses 1460 1553 +93
Continue to review full report at Codecov.
|
884a1c0
to
d7b0b29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
d7b0b29
to
93e2a45
Compare
Handles #86 in association with capsule-rs/sandbox#13.
Note: bench-pr job will break (only until merged) here as it's using the new container, which being on 19.11 dpdk, is a breaking change w/ master.