Problems checking size of argument names #5

Closed
captainbrosset opened this Issue Jan 25, 2012 · 3 comments

Comments

Projects
None yet
1 participant
Owner

captainbrosset commented Jan 25, 2012

$constructor : function (aEY, aBY) { --> no warning/error emitted
$constructor : function (lolilol, startY) { --> no warning/error emitted

Additionally, but probably harder, something like this:
function Point(x, y)
should ideally not output a warning for x and y being too short.

@ghost ghost assigned captainbrosset Jan 25, 2012

Owner

captainbrosset commented Jan 28, 2012

Ideally, something targeted at specific points of review would be needed:
// cleanjsoff:codesize:variablelength

This will require each reviewer to have a list of named review points.

Owner

captainbrosset commented Feb 25, 2012

Will create a new "feature" issue to implement the switch.
About the first comment: x/y are now in the dictionary, so this won't cause any problem.
Also, about aEY and aBY parameters: no error reported cause the words are split by camelcase = "a", "by", "ey", so, first word: "a" is in the dictionary, so ok, and then "by" and "ey" are not in the dictionary, so we fallback to the vowel/consonant ratio, which succeeds here ...
Only solution out of this is to connect to a true dictionary rather than calculating this fake ratio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment