Skip to content
Permalink
Browse files

Add linting tools and config.

Fix lint issues in otls.
  • Loading branch information
captainhammy committed Oct 20, 2019
1 parent dd9a62d commit a8e260689d1312f85d385bbd8b985f5d76ca81bc
Showing with 1,227 additions and 0 deletions.
  1. +22 −0 .flake8
  2. +330 −0 .pylint.rc
  3. +17 −0 Makefile
  4. +858 −0 bin/run_lint
  5. BIN houdini/otls/Driver-wedge.1.otl
  6. BIN houdini/otls/Sop-ngon.1.otl
22 .flake8
@@ -0,0 +1,22 @@
[flake8]
exclude =
docs/*
icons/*
python/ht/machinery/argparser.py
python/ht/ui/icons.py

max-line-length = 120

per-file-ignores =
houdini/pyfilter/ht-pyfilter.py:E402
houdini/python2.7libs/pythonrc.py:E402
houdini/scripts/*scenesave.py:F821
houdini/scripts/On*.py:F821
houdini/scripts/PreFirstCreate.py:F821
houdini/scripts/PostLastDelete.py:F821
houdini/scripts/SyncNodeVersion.py:F821
python/ht/events/__init__.py:F401
python/ht/logging/__init__.py:F401
python/ht/inline/lib.py:E122
python/ht/nodes/styles/__init__.py:F401
tests/*:E501
@@ -0,0 +1,330 @@

[MASTER]

extension-pkg-whitelist=PySide2

ignore=CVS
ignore-patterns=icons.py

persistent=no

load-plugins=

suggestion-mode=yes

unsafe-load-any-extension=no


[MESSAGES CONTROL]

disable=import-error,
line-too-long,
no-absolute-import,
duplicate-code,
fixme,
too-many-lines

enable=c-extension-no-member

[REPORTS]

evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)

output-format=text

reports=no

score=no


[REFACTORING]

max-nested-blocks=5

# Complete name of functions that never returns. When checking for
# inconsistent-return-statements if a never returning function is called then
# it will be considered as an explicit return statement and no message will be
# printed.
never-returning-functions=optparse.Values,sys.exit


[LOGGING]

# Logging modules to check that the string format arguments are in logging
# function parameter format
logging-modules=logging


[VARIABLES]
additional-builtins=

allow-global-unused-variables=yes

# A regular expression matching the beginning of the name of dummy variables
# (i.e. not used).
dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_

# Argument names that match this expression will be ignored. Default to name
# with leading underscore
ignored-argument-names=_.*|^ignored_|^unused_

init-import=no

# List of qualified module names which can have objects that can redefine
# builtins.
redefining-builtins-modules=six.moves,past.builtins,future.builtins,io,builtins


[FORMAT]

expected-line-ending-format=

# Regexp for a line that is allowed to be longer than the limit.
ignore-long-lines=^\s*(# )?<?https?://\S+>?$

# Number of spaces of indent required inside a hanging or continued line.
indent-after-paren=4

# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
# tab).
indent-string=' '

max-line-length=100

# Maximum number of lines in a module
max-module-lines=1000

# Allow the body of an if to be on the same line as the test if there is no
# else.
single-line-if-stmt=no

# List of optional constructs for which whitespace checking is disabled
no-space-check=trailing-comma,dict-separator


[SIMILARITIES]

# Ignore comments when computing similarities.
#ignore-comments=yes

# Ignore docstrings when computing similarities.
#ignore-docstrings=yes

# Ignore imports when computing similarities.
#ignore-imports=no

# Minimum lines number of a similarity.
#min-similarity-lines=4


[TYPECHECK]

# List of decorators that produce context managers, such as
# contextlib.contextmanager. Add to this list to register other decorators that
# produce valid context managers.
contextmanager-decorators=contextlib.contextmanager

# List of members which are set dynamically and missed by pylint inference
# system, and so shouldn't trigger E1101 when accessed. Python regular
# expressions are accepted.
generated-members=

# Tells whether missing members accessed in mixin class should be ignored. A
# mixin class is detected if its name ends with "mixin" (case insensitive).
ignore-mixin-members=yes

# This flag controls whether pylint should warn about no-member and similar
# checks whenever an opaque object is returned when inferring. The inference
# can return multiple potential results while evaluating a Python object, but
# some branches might not be evaluated, which results in partial inference. In
# that case, it might be useful to still emit no-member and other checks for
# the rest of the inferred objects.
ignore-on-opaque-inference=yes

# List of class names for which member attributes should not be checked (useful
# for classes with dynamically set attributes). This supports the use of
# qualified names.
ignored-classes=optparse.Values,
thread._local,
_thread._local,
Signal

# List of module names for which member attributes should not be checked
# (useful for modules/projects where namespaces are manipulated during runtime
# and thus existing member attributes cannot be deduced by static analysis. It
# supports qualified module names, as well as Unix pattern matching.
ignored-modules=

# Show a hint with possible names when a member name was not found. The aspect
# of finding the hint is based on edit distance.
missing-member-hint=yes

# The minimum edit distance a name should have in order to be considered a
# similar match for a missing member name.
missing-member-hint-distance=1

# The total number of similar names that should be taken in consideration when
# showing a hint for a missing member.
missing-member-max-choices=1

[MISCELLANEOUS]

# List of note tags to take in consideration, separated by a comma.
notes=FIXME,
XXX,
TODO,
BUG


[BASIC]

# Naming style matching correct argument names
argument-naming-style=snake_case

# Naming style matching correct attribute names
attr-naming-style=snake_case

# Bad variable names which should always be refused, separated by a comma
bad-names=foo,
bar,
foobar,
baz


# Naming style matching correct class attribute names
class-attribute-naming-style=any


# Naming style matching correct class names
class-naming-style=PascalCase


# Naming style matching correct constant names
#const-naming-style=UPPER_CASE

# Don't treat module-level names as constants because we lint so many scripts
# which get flagged as false positives.
const-rgx=(([a-zA-Z_][a-zA-Z0-9_]*)|(__.*__))$

# Minimum line length for functions/classes that require docstrings, shorter
# ones are exempt.
docstring-min-length=-1


# Naming style matching correct function names
function-naming-style=snake_case

# Good variable names which should always be accepted, separated by a comma
good-names=i,
j,
k,
t,
ex,
Run,
_

inlinevar-naming-style=any

# Naming style matching correct method names
method-naming-style=snake_case

# Naming style matching correct module names
#module-naming-style=snake_case
module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+)|([0-9]+))$

# Colon-delimited sets of names that determine each other's naming style when
# the name regexes allow several styles.
name-group=

# Regular expression which should only match function or class names that do
# not require a docstring.
no-docstring-rgx=^_

# List of decorators that produce properties, such as abc.abstractproperty. Add
# to this list to register other decorators that produce valid properties.
property-classes=abc.abstractproperty

# Naming style matching correct variable names
variable-naming-style=snake_case

# List of builtins function names that should not be used, separated by a comma
bad-functions=apply,input


[DESIGN]

# Maximum number of arguments for function / method
max-args=7

# Maximum number of attributes for a class (see R0902).
max-attributes=30

# Maximum number of boolean expressions in a if statement
max-bool-expr=5

# Maximum number of branch for function / method body
max-branches=40

# Maximum number of locals for function / method body
max-locals=15

# Maximum number of parents for a class (see R0901).
max-parents=7

# Maximum number of public methods for a class (see R0904).
max-public-methods=20

# Maximum number of return / yield for function / method body
max-returns=6

# Maximum number of statements in function / method body
max-statements=100

# Minimum number of public methods for a class (see R0903).
min-public-methods=0



[CLASSES]

# List of method names used to declare (i.e. assign) instance attributes.
defining-attr-methods=__init__,
__new__,
setUp

# List of valid names for the first argument in a class method.
valid-classmethod-first-arg=cls

# List of valid names for the first argument in a metaclass class method.
valid-metaclass-classmethod-first-arg=mcs


[IMPORTS]

# Allow wildcard imports from modules that define __all__.
allow-wildcard-with-all=no

# Deprecated modules which should not be used, separated by a comma
deprecated-modules=regsub,
TERMIOS,
Bastion,
rexec

# Create a graph of every (i.e. internal and external) dependencies in the
# given file (report RP0402 must not be disabled)
import-graph=

# Create a graph of external dependencies in the given file (report RP0402 must
# not be disabled)
ext-import-graph=

# Create a graph of internal dependencies in the given file (report RP0402 must
# not be disabled)
int-import-graph=


[EXCEPTIONS]

# Exceptions that will emit a warning when being caught. Defaults to
# "Exception"
overgeneral-exceptions=Exception,hou.Error
@@ -26,6 +26,23 @@ init-build:
mkdir -p ${CURDIR}/plugins/build
cd ${CURDIR}/plugins/build && hcmake ..

.PHONY: run-flake run-lint run-lint-py3k

# Run all linting targets
run-all-linting: run-flake run-lint run-lint-py3k

# Run flake8 linting
run-flake:
flake8

# Run python linting
run-lint:
bin/run_lint

# Run python linting against Python 3 compatibility
run-lint-py3k:
bin/run_lint --py3k

# Run Python unit tests
run-tests:
hython bin/run_tests.py

0 comments on commit a8e2606

Please sign in to comment.
You can’t perform that action at this time.