Fix Discover Card 403 by manually ordering HTTP headers

[fanqiuwen]

Since mid February Discover Card has been giving 403 Permission Denied for OFX requests that previously worked. It was discovered on OFX Home Forum that Discover now requires a particular set of HTTP headers ordered in a particular way. This PR implements the fix.

[jantman]

I can confirm that this fix works for me, though I'm still hitting #15 unless I add a sleep to cli.py.

[albaguirre]

Umm this didn't work for me. Still getting 403s.

[fanqiuwen]

@albaguirre The fix is still working for me.

I'm using ofxclient as a Python library, not a cli tool. For reference, here's a minimal version of my script that downloads Discover transactions successfully, given the changes in this PR.

from ofxclient import Institution, CreditCardAccount
discover_args = {
    'id': '7101',
    'org': 'Discover Financial Services',
    'url': 'https://ofx.discovercard.com',
    'username': 'SECRET',
    'password': 'SECRET',
    'client_args': {
        'app_id': 'QWIN',
        'app_version': '2200',
        'ofx_version': '102'
        }
    }
discover = CreditCardAccount(institution=Institution(**discover_args),
                             number='SECRET')
for tran in discover.transactions():
    print(tran.payee, tran.amount)

If this works for you and the cli doesn't, then it would be a separate issue.

[albaguirre]

@fanqiuwen Huh that snippet does indeed work. But CLI doesn't ... interesting.

[jantman]

Cool, thank you so much for merging! Any chance we could get a release uploaded to PyPI?

[captin411]

Sure I'll get one out this afternoon. David Bartle Mobile: 805-345-6786

…

On Apr 22, 2017, at 4:53 AM, Jason Antman ***@***.***> wrote: Cool, thank you so much for merging! Any chance we could get a release uploaded to PyPI? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.