Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog link to NodeJS #43

Merged
merged 5 commits into from Jun 2, 2019

Conversation

Projects
None yet
2 participants
@jhnferraris
Copy link
Collaborator

commented May 30, 2019

Starting point for - #39

@captn3m0

This comment has been minimized.

Copy link
Owner

commented Jun 1, 2019

I don't know if it is possible, but I was hoping we could write a meta template inside the page that can then generate the link by itself.

For eg, given (r=)

  - releaseCycle: 12
    release: 2019-10-22
    lts: true
    lts: false
    support: 2021-04-01
    eol: 2021-04-01
    latest: v12.3.1
    changelog: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md

if we add this:

layout: post
changeLogLinkTemplate: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V{{releaseCycle}}.md#{{latest | slice: 1,latest.size }}

And that generates the correct link by itself.

@jhnferraris

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 2, 2019

Hey @captn3m0 , sorry to get back to you this late. I'm currently out of town and network kinda sucks.

Anyway, I also do not know if the meta template could work. I'll check if a string replace is possible when we put it in the template. We should also take note that some tools (but not all, i.e iPhone) do not have change logs in them. How will we approach this?

@captn3m0

This comment has been minimized.

Copy link
Owner

commented Jun 2, 2019

@jhnferraris

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 2, 2019

Updated PR. I also had to removed v on the latest value to point to the correct link. 👍

@captn3m0

This comment has been minimized.

Copy link
Owner

commented Jun 2, 2019

Looks great 👍

Minor suggestion, replace LATEST with %LATEST% and RELEASE_CYCLE with %RELEASE_CYCLE% (or something similar) to avoid issues down the line?

@jhnferraris

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 2, 2019

Used a "double underscore" so we won't confused % with actual urls that has % in them. hehe

@jhnferraris jhnferraris merged commit 4b8a04b into master Jun 2, 2019

2 of 5 checks passed

Header rules No header rules processed
Details
Pages changed 5 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details

@captn3m0 captn3m0 deleted the changelog-link branch Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.