Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add react 18 as peerDep, update componentDidMount logic for StrictMode #1364

Merged
merged 1 commit into from
May 16, 2022
Merged

feat(react): add react 18 as peerDep, update componentDidMount logic for StrictMode #1364

merged 1 commit into from
May 16, 2022

Conversation

theiliad
Copy link
Member

@theiliad theiliad commented May 16, 2022 •
edited
Loading

Closes #1357

@theiliad theiliad requested review from Akshat55 and a team as code owners May 16, 2022 17:30
@theiliad theiliad requested review from zvonimirfras and Donisius and removed request for a team May 16, 2022 17:30
dabrad26
dabrad26 approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@dabrad26 dabrad26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! hasChartBeenInitialized is nice and clean for the StrictMode! Thanks

@theiliad theiliad merged commit 9af452f into carbon-design-system:master May 16, 2022
@theiliad theiliad deleted the react-strict branch May 16, 2022 21:05
@MichaelDimmitt
Copy link

MichaelDimmitt commented Sep 6, 2022 •
edited
Loading

@theiliad , do we still need to disable strict mode with this ?
I see that it is in the codebase but how do you implement it from a functional component importing a chart?

@dhenneke dhenneke mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabrad26 dabrad26 dabrad26 approved these changes

@Akshat55 Akshat55 Awaiting requested review from Akshat55

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras zvonimirfras is a code owner automatically assigned from carbon-design-system/carbon-charts

@Donisius Donisius Awaiting requested review from Donisius Donisius is a code owner automatically assigned from carbon-design-system/carbon-charts

Assignees
No one assigned
Labels
package: react type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Carts render twice when React Strict Mode is on
3 participants
@theiliad @MichaelDimmitt @dabrad26