Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cv-data-table listener is called after navigation #1089

Merged
merged 2 commits into from Dec 11, 2020
Merged

fix: cv-data-table listener is called after navigation #1089

merged 2 commits into from Dec 11, 2020

Conversation

Fontinalis
Copy link
Contributor

Closes #1088

Removes the listeners from the original component definition, and adds the blur listeners to the magnifier and search components in the mounted function. At the end, in the beforeDestroy function, it removes the listeners to prevent the issue described in #1088 . It also checks if the searchContainer component exists, to prevent the same, undefined error happening.

Changelog

M packages/core/src/components/cv-data-table/cv-data-table.vue

@netlify
Copy link

netlify bot commented Dec 3, 2020

✔️ Deploy preview for carbon-components-vue ready!

🔨 Explore the source changes: 6636def

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-vue/deploys/5fd3964ab3e936000715f505

😎 Browse the preview: https://deploy-preview-1089--carbon-components-vue.netlify.app

@lee-chase lee-chase merged commit 68a18d5 into carbon-design-system:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cv-data-table: checkSearchFocus listener is called after navigation
2 participants