Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendors css is not created since v2.30.0-canary.0 #997

Closed
mawwerik opened this issue Sep 2, 2020 · 10 comments
Closed

vendors css is not created since v2.30.0-canary.0 #997

mawwerik opened this issue Sep 2, 2020 · 10 comments

Comments

@mawwerik
Copy link

mawwerik commented Sep 2, 2020

Detailed description

When I run yarn build I would expect that the build process (vue-cli-service build) creates 4 files:

dist/js/chunk-vendors.xxx.js
dist/js/app.xxx.js
dist/css/chunk-vendors.xxx.css
dist/css/app.xxx.css

image

This worked fine up until @carbon/vue 2.29.0.

Since @carbon/vue 2.30.0-canary.0 the dist/css/chunk-vendors.xxx.css is not created anymore.
image

Steps to reproduce the issue

  1. In package.json in dependencies section change the version number of @carbon/vue to 2.30.0-canary.0

image

  1. Run yarn install
  2. Run yarn build
@lee-chase
Copy link
Member

I am unable to replicate this behaviour by simply changing between versions of @carbon/vue I always get the latter.

Are you able to create a simple project on github demonstrating this issue? Perhaps with before and after branches.

@mawwerik
Copy link
Author

mawwerik commented Sep 7, 2020

Hi @lee-chase,

Please remove the ^ sign in front of the version number of @carbon/vue. Refer with the exact version numbers:

  1. "@carbon/vue": "2.30.0-canary.0"
  2. "@carbon/vue": "2.29.0"

@lee-chase
Copy link
Member

When I build with 2.29.0 I get the following which would appear to place the contents of the vendors css in the app css file

image

@mawwerik
Copy link
Author

mawwerik commented Sep 9, 2020

@lee-chase 2.29.0 is fine. Pls run with version 2.30.0-canary.0.

@hammertoe
Copy link

I am seeing the same with project on IBM internal Github: https://github.ibm.com/Matthew-Hamilton1/vcpi-tool

matt@Matts-MBP dist % find . -ls
9906263        0 drwxr-xr-x    6 matt             staff                 192 11 Sep 00:02 .
9906266        8 -rw-r--r--    1 matt             staff                 726 11 Sep 00:02 ./index.html
9906264        0 drwxr-xr-x    3 matt             staff                  96 11 Sep 00:02 ./css
9906268        8 -rw-r--r--    1 matt             staff                 145 11 Sep 00:02 ./css/app.c174350d.css
9906265        0 drwxr-xr-x    6 matt             staff                 192 11 Sep 00:02 ./js
9906269       24 -rw-r--r--    1 matt             staff                9268 11 Sep 00:02 ./js/app.1e4513e3.js
9906272      920 -rw-r--r--    1 matt             staff              470074 11 Sep 00:02 ./js/chunk-vendors.cac694d5.js
9906271     3704 -rw-r--r--    1 matt             staff             1893347 11 Sep 00:02 ./js/chunk-vendors.cac694d5.js.map
9906270       56 -rw-r--r--    1 matt             staff               26112 11 Sep 00:02 ./js/app.1e4513e3.js.map
9906267        8 -rw-r--r--    1 matt             staff                1077 11 Sep 00:02 ./bee_128.png
matt@Matts-MBP vcpi-tool % grep carbon package.json 
    "@carbon/vue": "^2.33.0",

@lee-chase
Copy link
Member

Thanks @hammertoe. Playing with your repository appears to suggest that when carbon moved from v10.12.0 to 10.13.0-rc.0 the vendors css file stops getting generated.

This does

yarn add carbon-components@10.12.0

This does not

yarn add carbon-components@10.13.0

I have not been able to determine why, but the carbon-components css build is outside of my control.

@lee-chase
Copy link
Member

OK @hammertoe and @mawwerik I now know what is happening.

This https://github.com/carbon-design-system/carbon/pull/5987/files added sideEffects to carbon-components package.json. It results in vender css files not being created.

Submitted this issue carbon-design-system/carbon#6824

@mawwerik
Copy link
Author

@lee-chase thanks for your contribution and help.

@lee-chase
Copy link
Member

Looks like this will be resolved with carbon-components 10.20.0

@lee-chase
Copy link
Member

Resolved in 10.20.0 of carbon-components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants