Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singular action button for existing modal component. #116

Closed
heatherco opened this issue May 22, 2019 · 5 comments

Comments

@heatherco
Copy link

commented May 22, 2019

Detailed description

Describe in detail the issue you're having. Please include whether or not this is part of Sketch Libraries or the larger Sketch Kit file.

Add singular action button for existing modal component.

What version of the Carbon Design System Kit are you using?
10

Is this issue related to a specific component? If so please give the page, artboard, and layer/symbol name.
image

@stale

This comment has been minimized.

Copy link

commented Jun 14, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Jun 14, 2019

@heatherco

This comment has been minimized.

Copy link
Author

commented Jun 15, 2019

Hi Lauren, just an FYI, as a temporary solution to this, I used the model component with a left and right button. I set the right button without any text and give it the same link.
Maybe you can provide this as a temporary options for those who only need one button until a component can be created.
image (16)

@stale stale bot removed the inactive label Jun 15, 2019

@stale

This comment has been minimized.

Copy link

commented Jun 29, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Jun 29, 2019

@stale

This comment has been minimized.

Copy link

commented Jul 2, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this Jul 2, 2019

@aagonzales aagonzales reopened this Jul 8, 2019

@stale stale bot removed the inactive label Jul 8, 2019

@aagonzales

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Added! It will be available in the next kit update.

It is not its own modal variation but we've added a footer modifier in the transitional modal that allows you to switch between single and double actions in the symbol overrides pattern.

image

@aagonzales aagonzales closed this Jul 8, 2019

@aagonzales aagonzales referenced this issue Jul 11, 2019
24 of 41 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.