Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropdown symbol missing overrides... #125

Closed
marceltrautmann opened this issue Jun 17, 2019 · 6 comments

Comments

@marceltrautmann
Copy link

commented Jun 17, 2019

Working with the individual pieces of the dropdown symbol in sketch (white theme). Notice that the overrides seem to be missing from the "first" element (as compared to the middle/last). Specifically field colour in this instance. See screenie for details

image

Side note: shouldn't it follow the 8pixel grid? note the slight overhang.

@stale

This comment has been minimized.

Copy link

commented Jul 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Jul 1, 2019

@stale

This comment has been minimized.

Copy link

commented Jul 4, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this Jul 4, 2019

@marceltrautmann

This comment has been minimized.

Copy link
Author

commented Jul 8, 2019

open

@aagonzales aagonzales reopened this Jul 8, 2019

@stale stale bot removed the inactive label Jul 8, 2019

@marceltrautmann

This comment has been minimized.

Copy link
Author

commented Jul 8, 2019

This guidance might apply here as well...

image
https://ibm-studios.slack.com/archives/C0M053VPT/p1561469191349600

@aagonzales

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

We can't technically do it like that though. In code we'd have to add javascript to all our basic components to get them to hit mini-unit increments and our devs think that is a bad practice (to add unnecessary javascript). Therefore with these Sketch components we're following the dev functionality. Mike knows this is the reason why things don't fall on the mini unit. In a perfect design bubble world, everything would be evenly sized and on the mini unit.

@aagonzales

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Missing overrides issue is fixed, it will be available in the next update.

@aagonzales aagonzales closed this Jul 9, 2019

@aagonzales aagonzales referenced this issue Jul 11, 2019
24 of 41 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.