Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put comma inside quotes #1315

Closed
wants to merge 1 commit into from

Conversation

@xylish7 xylish7 requested a review from a team June 23, 2020 14:22
@xylish7 xylish7 requested a review from a team as a code owner June 23, 2020 14:22
@ghost ghost requested review from aledavila and dakahn June 23, 2020 14:23
@vercel
Copy link

vercel bot commented Jun 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/co60rhrzz
✅ Preview: https://carbon-website-git-fork-xylish7-fix-typoraphy.carbon-design-system.vercel.app

Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the punctuation as shown is correct. It is following the IBM Style, details of which can be found here under the heading Quotation marks with other punctuation
: https://apps.na.collabserv.com/wikis/home?lang=en-us#!/wiki/W580a84a67242_4da6_81cf_69e3db4bdbfa/page/Quotation%20marks

If a punctuation mark is part of a quotation (or of a programming element that uses quotation marks), place the punctuation mark inside the closing quotation mark; otherwise, place it outside the closing quotation mark. If a sentence ends with a quotation, use only one period, question mark, or exclamation point to end the sentence, placing it inside the closing quotation mark if it is part of the quotation, and outside if it is not.

If you see it on other parts of the site not following that IBM Style rule, it's only because we haven't reviewed those pages yet but we will be reviewing in the future to ensure that we're consistent.

@xylish7
Copy link
Author

xylish7 commented Jun 23, 2020

@janchild I was told by @vpicone to replicate this PR here. The decision to make this doesn't belong to me, but to the copywriter of the design-language-website, where this change was also made.

@vpicone
Copy link
Contributor

vpicone commented Jun 23, 2020

Oh interesting! Perhaps we should revert the IDL change. @xylish7 can you show your content author/designer @janchild's comment here? If they still want to diverge, that's their prerogative, but we should inform them it's counter to IBM style.

@xylish7
Copy link
Author

xylish7 commented Jun 23, 2020

Sure! I gave her the link to this issue and waiting for her response.

@mjabbink
Copy link
Contributor

mjabbink commented Jun 23, 2020

@xylish7 @vpicone I think @janchild is correct and the styling should stay as it was with the comma outside the quote in this case.

@vpicone
Copy link
Contributor

vpicone commented Jun 23, 2020

@xylish7 great! going to close this for now

@vpicone vpicone closed this Jun 23, 2020
@xylish7 xylish7 deleted the fix/typoraphy branch June 23, 2020 16:51
@mjabbink
Copy link
Contributor

but this was executed as far as I can see and needs to revert.

@vpicone
Copy link
Contributor

vpicone commented Jun 23, 2020

@mjabbink this PR is in the carbon website repo, it wasn't merged here. The one that'll be reverted is in IDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants