New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: put comma inside quotes #1315
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/co60rhrzz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the punctuation as shown is correct. It is following the IBM Style, details of which can be found here under the heading Quotation marks with other punctuation
: https://apps.na.collabserv.com/wikis/home?lang=en-us#!/wiki/W580a84a67242_4da6_81cf_69e3db4bdbfa/page/Quotation%20marks
If a punctuation mark is part of a quotation (or of a programming element that uses quotation marks), place the punctuation mark inside the closing quotation mark; otherwise, place it outside the closing quotation mark. If a sentence ends with a quotation, use only one period, question mark, or exclamation point to end the sentence, placing it inside the closing quotation mark if it is part of the quotation, and outside if it is not.
If you see it on other parts of the site not following that IBM Style rule, it's only because we haven't reviewed those pages yet but we will be reviewing in the future to ensure that we're consistent.
Sure! I gave her the link to this issue and waiting for her response. |
@xylish7 great! going to close this for now |
but this was executed as far as I can see and needs to revert. |
@mjabbink this PR is in the carbon website repo, it wasn't merged here. The one that'll be reverted is in IDL. |
Closes :
Changelog
Changed