Skip to content

Commit 7f49424

Browse files
timfuhrmannheloiseluitay1orjonesariellalgilmore
authored
feat(modal): mount/unmount on open change (#19531)
* feat(modal): add presence * feat(modal): fix imports * feat(modal): remove leftover hook * feat(modal): fix typo * feat(modal): move story * feat(modal): disable presence * feat(ComposedModal): add support for uncontrolled composed modal * chore(ComposedModal): add storybook documentation * fix(usePresence): fix linting * fix(Modal): fix stories * docs(enable-presence): add to feature flag overview page * chore(test): update snapshots --------- Co-authored-by: Heloise Lui <71858203+heloiselui@users.noreply.github.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> Co-authored-by: Taylor Jones <taylor.jones826@gmail.com> Co-authored-by: ariellalgilmore <ariellalgilmore@gmail.com>
1 parent 6f38b33 commit 7f49424

26 files changed

+2193
-613
lines changed

packages/feature-flags/feature-flags.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,3 +64,7 @@ feature-flags:
6464
richer callback data and expanded trigger events for onChange and
6565
onDelete.
6666
enabled: false
67+
- name: enable-presence
68+
description: >
69+
Enable components to remain unmounted in closed state and mount in open state.
70+
enabled: false

packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1666,6 +1666,7 @@ Map {
16661666
},
16671667
"render": [Function],
16681668
},
1669+
"ComposedModalPresence" => {},
16691670
"ContainedList" => {
16701671
"ContainedListItem": {
16711672
"propTypes": {
@@ -6741,6 +6742,7 @@ Map {
67416742
},
67426743
"render": [Function],
67436744
},
6745+
"ModalPresence" => {},
67446746
"ModalWrapper" => {
67456747
"propTypes": {
67466748
"buttonTriggerClassName": {

packages/react/src/__tests__/index-test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ describe('Carbon Components React', () => {
4949
"ComboBox",
5050
"ComboButton",
5151
"ComposedModal",
52+
"ComposedModalPresence",
5253
"ContainedList",
5354
"ContainedListItem",
5455
"Content",
@@ -147,6 +148,7 @@ describe('Carbon Components React', () => {
147148
"ModalBody",
148149
"ModalFooter",
149150
"ModalHeader",
151+
"ModalPresence",
150152
"ModalWrapper",
151153
"MultiSelect",
152154
"NotificationActionButton",

0 commit comments

Comments
 (0)