fix(overflow-menu): use correct icon color for danger items

[emyarod]

Closes #2971

This PR matches SVG icon color with text color in danger/delete variant overflow menu items on hover (similar to icons in buttons)

Changelog

Changed

• isDelete overflow menu item SVG icon hover color

Testing / Reviewing

Add an icon to an overflow menu item with isDelete={true} to test. as far as I know this isn't a pattern that we expose on our docs so it isn't viewable on Netlify

you can test this by modifying one of the overflow menu items in storybook to

<OverflowMenuItem
  {...overflowMenuItemProps}
  itemText={
    <>
      <Delete16 /> Danger option
    </>
  }
  hasDivider
  isDelete
/>

[netlify]

Deploy preview for the-carbon-components ready!

Built with commit de02a5b

https://deploy-preview-3147--the-carbon-components.netlify.com

[netlify]

Deploy preview for carbon-components-react ready!

Built with commit de02a5b

https://deploy-preview-3147--carbon-components-react.netlify.com

[netlify]

Deploy preview for carbon-elements ready!

Built with commit de02a5b

https://deploy-preview-3147--carbon-elements.netlify.com

[joshblack]

@emyarod mind checking in the built files? I think it'll just be yarn docs in packages/components

[asudoh]

@joshblack Seems that this is style-only change with a few lines...?

[joshblack]

@asudoh since it uses a token, the SassDoc for components needs to be updated since it captures token usage.

[asudoh]

@joshblack Sounds that this topic requires update to contributor guide. Would you please do? Thanks!

[emyarod]

updated the sassdoc but the error still persists, does the script need to be tweaked?

[jnm2377]

Try running yarn build at the top-level. That's what I had to do for one of my PR's that was failing with the same error.