Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toggle): convert ToggleSmall to a variant of Toggle #7380

Merged
merged 3 commits into from
Dec 4, 2020
Merged

feat(toggle): convert ToggleSmall to a variant of Toggle #7380

merged 3 commits into from
Dec 4, 2020

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Dec 1, 2020

Closes #6653
Closes #7327
Refs carbon-design-system/carbon-components-svelte#401

Deprecates ToggleSmall and adds size prop to Toggle since the two components are basically identical.

Changelog

New

  • size prop for Toggle that accepts sm to enable the small toggle variant
  • Tests for the new prop in Toggle

Changed

  • Added deprecation warnings when using ToggleSmall in Dev mode
  • Added deprecation notes for ToggleSmall to the storybook
  • Workarounds to keep ToggleSmall tests from failing because of the deprecation warning

Removed

  • Unnecessary stories

Testing / Reviewing

Try changing the size of Toggle in the storybook and ensure all styles look correct

@tw15egan tw15egan requested review from a team as code owners December 1, 2020 20:43
@tw15egan tw15egan requested review from emyarod, andreancardona, a team and jeanservaas and removed request for a team December 1, 2020 20:43
@netlify
Copy link

netlify bot commented Dec 1, 2020

Deploy preview for carbon-elements ready!

Built with commit 4b9c6b9

https://deploy-preview-7380--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 1, 2020

Deploy preview for carbon-components-react ready!

Built with commit 4b9c6b9

https://deploy-preview-7380--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Dec 1, 2020 •
edited
Loading

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: c10b592

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fca50e181be9c0008e2211a

😎 Browse the preview: https://deploy-preview-7380--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 1, 2020 •
edited
Loading

✔️ Deploy preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: c10b592

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5fca50e1fe6dc600079e8137

😎 Browse the preview: https://deploy-preview-7380--carbon-components-react.netlify.app

jeanservaas
jeanservaas approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

andreancardona
andreancardona approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

emyarod
emyarod approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

packages/react/src/components/ToggleSmall/ToggleSmall-test.js Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 336b7de into carbon-design-system:master Dec 4, 2020
@emyarod emyarod mentioned this pull request Feb 5, 2021
Merged
@janhassel janhassel mentioned this pull request Mar 23, 2021
Merged
@tw15egan tw15egan deleted the toggle-small-refactor branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@andreancardona andreancardona andreancardona approved these changes

@jeanservaas jeanservaas jeanservaas approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React ToggleSmall params typing requires aria-label parameter ToggleSmall should be a variant of toggle
4 participants
@tw15egan @emyarod @andreancardona @jeanservaas