Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Toggle): support labels for small toggles #7752

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 5, 2021

Closes #7750

related #6653 #7380

This PR supports visible inline labels on the small toggle component

Testing / Reviewing

Confirm that labels are now visible on the small toggle component when a label value is provided

@netlify
Copy link

netlify bot commented Feb 5, 2021

Deploy preview for carbon-elements ready!

Built with commit 636af2c

https://deploy-preview-7752--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 5, 2021

Deploy preview for carbon-components-react ready!

Built with commit 636af2c

https://deploy-preview-7752--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Feb 5, 2021

Deploy preview for carbon-elements ready!

Built with commit 90a0440

https://deploy-preview-7752--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 5, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 90a0440

https://deploy-preview-7752--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle in small size is not displaying labels
5 participants