Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update theme #87

Merged

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Jul 10, 2019

No description provided.

@netlify
Copy link

netlify bot commented Jul 10, 2019

Deploy preview for design-language-website ready!

Built with commit e278095

https://deploy-preview-87--design-language-website.netlify.com

@vpicone
Copy link
Contributor Author

vpicone commented Jul 10, 2019

@alisonjoseph looks like it’s working 🤷‍♂

@alisonjoseph
Copy link
Member

why do you have so many more changes than my new PR? Also, this seems to be missing the package.json update?

@vpicone
Copy link
Contributor Author

vpicone commented Jul 10, 2019

@alisonjoseph When using yarn, it doesn't update package.json unless it changes the semver. Since 1.4.0 still matches ^1.3.5 only the yarn lock gets updated (^1.3.5 in the package.json will still download 1.4.0).

To do updates in yarn I usually just use yarn upgrade-interactive or yarn upgrade gatsby-theme-carbon. Manually changing the package.json doesn't always work out.

@alisonjoseph
Copy link
Member

That makes sense, but I also like updating the package.json so I can see what version I'm on (more specifically for the theme than any of the other packages)

@alisonjoseph alisonjoseph merged commit 50ef637 into carbon-design-system:master Jul 10, 2019
@vpicone
Copy link
Contributor Author

vpicone commented Jul 10, 2019

@alisonjoseph the yarn blog actually recommends removing the package, clearing the yarn cache, then adding it back which would update the package.json and clear out all the unused deps

I think the removed mirrors are what was missing from your fork

@vpicone vpicone deleted the update-gatsby-theme branch July 10, 2019 12:35
@alisonjoseph
Copy link
Member

alisonjoseph commented Jul 10, 2019

I usually run rm -rf .yarn-offline-mirror node_modules && yarn cache clean && yarn install when updating packages 🤷‍♀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants