Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing audit #252

Open
alisonjoseph opened this issue Jul 16, 2019 · 5 comments

Comments

@alisonjoseph
Copy link
Member

commented Jul 16, 2019

We have multiple bugs/issues around spacing, need to sync up w/ @jeanservaas and @sadek to make sure spacing above/below components and headings are correct. Need to look at the site/components as a whole and not just individually.

@alisonjoseph alisonjoseph added this to To Do in IDL site QA/release via automation Jul 16, 2019

@alisonjoseph alisonjoseph moved this from To Do to In progress in IDL site QA/release Jul 18, 2019

@alisonjoseph

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

We have a meeting planned for Tuesday 7/30 to solve this.

@abbeyhrt would it be possible for you to create a demo page in the theme with al(as many as possible) variations on components before/after headings, paragraphs etc prior to this meeting? We don't need to merge it in, we can keep it in a draft PR / branch, but just somewhere we can work from and see things.

@vpicone

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2019

Adding #271 to the list of review needs. Spacing in and among lists needs to be better defined when they contain things like code snippets or images.

@abbeyhrt

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@alisonjoseph Sorry i didn't see this earlier! But yes, I can get that done ASAP and definitely before Tuesday 7/30

@vpicone

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

Adding this here for discussion: https://csswizardry.com/2012/06/single-direction-margin-declarations/

Definitely worth the read before we discuss the sort of design direction would be most scaleable

@vpicone

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Another great resource: https://every-layout.dev/layouts/stack/

@alisonjoseph alisonjoseph moved this from In progress to To Do in IDL site QA/release Aug 12, 2019

@alisonjoseph alisonjoseph removed this from To Do in IDL site QA/release Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.