-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maestro Dapp Platform builder tool #1047
Conversation
From a quick look it might be better suited in the showcase section. (Similar to other services not a direct builder tool) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katomm at first glance I also thought this was a user-level service, and therefore better in the Showcase, because the ISPO Marketplace (https://www.gomaestro.org/marketplace) is at the very top of the home page. This is definitely something Ada delegators will be & probably have been using as a reference.
But all the other documented items are services for builders. @Vardominator I assume the site is set up this way because your Plans page (https://www.gomaestro.org/pricing) > "Promote your ISPO" shows paid tiers which base upon listing on this page.
What makes me unhappy about this arrangement: the only thing currently alerting the user community to this paid-placement model is the term "Featured ISPOs" without a link or a bubble explaining how this works. Many will recognise it's a paid placement but even more will not.
My concern and your overall goal would both be satisfied if you made "Featured ISPOs" a link to https://www.gomaestro.org/pricing#promote-ISPO - so both your users and buyers can see what it's all about.
Otherwise I think this is a good-to-go builder tool as per the services on https://docs.gomaestro.org . @Vardominator to help qualify the significance of this service, were you the ones who actually executed the Genius Yield ISPO?
➡️ One change I would request for the project image: what is apparently a screenshot has an artefact "News" with an horizontal bar at the top of it. That word will be unreadable at the dot pitch these logos are displayed. Can you trim that off? If so it'll better fit the 2.1:1 aspect ratio and leave viewers with only clearly readable text and illustration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also submitted https://github.com/maestro-org/developer-portal/pull/1 (we can't edit your branch, inconveniently) to remove sdk
tag vs. the other projects you can see listed here https://developers.cardano.org/tools?tags=sdk - since I don't see development libraries anywhere (https://docs.gomaestro.org).
@rphair @katomm @fill-the-fill Can you please check my latest updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All points for improvement are addressed in my opinion. Magenta writing on logo is too small to be universally legible in its displayed scale, but that's up to the submitter.
@katomm @fill-the-fill can you please approve? |
@rphair When does this go into production? |
@Vardominator generally editors can't even predict this. Periodically, as you can imagine, |
Checklist
yarn build
after adding my changes without getting any errors.Builder Tool addition
http
hosted