Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano node install - added libsecp256k1 details and more #675

Merged
merged 5 commits into from
Jul 4, 2022

Conversation

os11k
Copy link
Collaborator

@os11k os11k commented Jun 30, 2022

Updating documentation

Description of the change

Updated cardano node installation page. Added details regarding new requirement - libsecp256k1 and how we can compile it. Added details regarding new system requirements. Updated links with latest binaries.

Cardano node installation - added libsecp256k1 details
Updated installing-cardano-node.md with new system requirements
@os11k os11k changed the title Cardano node install - added libsecp256k1 details Cardano node install - added libsecp256k1 details and more Jun 30, 2022
Updated links to latest binaries in installing-cardano-node.md
Copy link
Collaborator

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left couple of comments about including make check to run tests - tho not essential for most, it provides LD link error details when dependencies fail

os11k and others added 2 commits July 1, 2022 09:25
Added "make check" when building Secp256k1, as advised by @rdlrt

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
Added "make check" when building Secp256k1, as advised by @rdlrt

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
@os11k
Copy link
Collaborator Author

os11k commented Jul 1, 2022

Added "make check" when building Secp256k1, as advised by @rdlrt

@rdlrt rdlrt merged commit 5a13d93 into staging Jul 4, 2022
@rdlrt rdlrt deleted the os11k-patch-1 branch July 4, 2022 23:15
thenic95 added a commit to thenic95/developer-portal that referenced this pull request Jul 8, 2022
…into staging

* 'staging' of https://github.com/thenic95/developer-portal:
  fix: broken link on integrate cardano page (cardano-foundation#661)
  Cardano node install - added libsecp256k1 details and more (cardano-foundation#675)
  Update MuesliSwap landing page image (cardano-foundation#673)
  Add period at the end of description for all showcases/builder tools (cardano-foundation#668)
  Add eUTxO showcase (cardano-foundation#667)
  new pages: Air Gap Environment, Secure Transaction Workflow (cardano-foundation#665)
  Added cscli to builder tools with new 'CLI' tag and corresponding getting started docs (cardano-foundation#664)
  Update docusaurus.config.js (cardano-foundation#658)
  add testnet explorer (cardano-foundation#671)

# Conflicts:
#	src/data/showcases.js
thenic95 added a commit to thenic95/developer-portal that referenced this pull request Jul 8, 2022
…into staging

* 'staging' of https://github.com/thenic95/developer-portal:
  Name change of community advisor role (cardano-foundation#677)
  Add ImperatorLang (cardano-foundation#672)
  fix: broken link on integrate cardano page (cardano-foundation#661)
  Cardano node install - added libsecp256k1 details and more (cardano-foundation#675)
  Update MuesliSwap landing page image (cardano-foundation#673)
  Add period at the end of description for all showcases/builder tools (cardano-foundation#668)
  Add eUTxO showcase (cardano-foundation#667)
  new pages: Air Gap Environment, Secure Transaction Workflow (cardano-foundation#665)
  Added cscli to builder tools with new 'CLI' tag and corresponding getting started docs (cardano-foundation#664)
  Update docusaurus.config.js (cardano-foundation#658)
  add testnet explorer (cardano-foundation#671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants