-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardano node install - added libsecp256k1 details and more #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cardano node installation - added libsecp256k1 details
Updated installing-cardano-node.md with new system requirements
Updated links to latest binaries in installing-cardano-node.md
rdlrt
reviewed
Jun 30, 2022
rdlrt
reviewed
Jun 30, 2022
rdlrt
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left couple of comments about including make check to run tests - tho not essential for most, it provides LD link error details when dependencies fail
Added "make check" when building Secp256k1, as advised by @rdlrt |
rdlrt
approved these changes
Jul 1, 2022
katomm
approved these changes
Jul 1, 2022
fill-the-fill
approved these changes
Jul 4, 2022
thenic95
added a commit
to thenic95/developer-portal
that referenced
this pull request
Jul 8, 2022
…into staging * 'staging' of https://github.com/thenic95/developer-portal: fix: broken link on integrate cardano page (cardano-foundation#661) Cardano node install - added libsecp256k1 details and more (cardano-foundation#675) Update MuesliSwap landing page image (cardano-foundation#673) Add period at the end of description for all showcases/builder tools (cardano-foundation#668) Add eUTxO showcase (cardano-foundation#667) new pages: Air Gap Environment, Secure Transaction Workflow (cardano-foundation#665) Added cscli to builder tools with new 'CLI' tag and corresponding getting started docs (cardano-foundation#664) Update docusaurus.config.js (cardano-foundation#658) add testnet explorer (cardano-foundation#671) # Conflicts: # src/data/showcases.js
thenic95
added a commit
to thenic95/developer-portal
that referenced
this pull request
Jul 8, 2022
…into staging * 'staging' of https://github.com/thenic95/developer-portal: Name change of community advisor role (cardano-foundation#677) Add ImperatorLang (cardano-foundation#672) fix: broken link on integrate cardano page (cardano-foundation#661) Cardano node install - added libsecp256k1 details and more (cardano-foundation#675) Update MuesliSwap landing page image (cardano-foundation#673) Add period at the end of description for all showcases/builder tools (cardano-foundation#668) Add eUTxO showcase (cardano-foundation#667) new pages: Air Gap Environment, Secure Transaction Workflow (cardano-foundation#665) Added cscli to builder tools with new 'CLI' tag and corresponding getting started docs (cardano-foundation#664) Update docusaurus.config.js (cardano-foundation#658) add testnet explorer (cardano-foundation#671)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating documentation
Description of the change
Updated cardano node installation page. Added details regarding new requirement - libsecp256k1 and how we can compile it. Added details regarding new system requirements. Updated links with latest binaries.