-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LodeWallet to Showcase #915
Add LodeWallet to Showcase #915
Conversation
Reasons for not approving for me:
|
As an alternative for Description, how about:
Yes, seems too subjective to block inclusion or warrant further discussion. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get behind it either, mostly because of the reasons @rdlrt already pointed out. If the "simplest possible experience" included anything that the other light wallets had missed, I would happily endorse it: but right now it just provides the same shell as other wallets like Nami but without the breadth of user-demanded features (these tend to be neither superfluous nor distracting).
One feature I'm waiting to see in browser extension wallets is to give users full web pages (like Yoroi has had since the beginning) rather than mobile screens translated into browser popups. The screenshots on the Google Play page tell yet another story of the entire UI being confined by whatever tools & libraries were used to generate the mobile app view. Yes this is the trend in crypto wallets but no I don't have to like it, and objectively this is just another way in which this wallet fails to distinguish itself (and if LodeWallet did provide this feature, I would also be willing to endorse it).
Another reason I'd endorse it (which I don't see in this case) would be a more explicit, verifiable, objective demonstration of how the wallet's "making direct use of existing open-source Cardano Haskell libraries" provides any benefit for the user. Until proven otherwise, this is just an implementation detail & marketing premise which is separate from any aspect of the user experience (if only to inspire the user's confidence... if and only if you can justify why that is so).
@chobbins: Yes, seems too subjective to block inclusion or warrant further discussion.
There is never going to be a case when a reviewer's subjective statement blocks discussion. By the same token, if a reviewer comes forward with a subjective opinion it means they're prepared to justify it according to their understanding of industry best practice & the content guidelines for the Portal. As I see it @rdlrt's statement was an invitation to further discussion rather than a closure, as is my own review... and I'll tag a few more reviewers to ensure this opportunity. 😎
Fair enough! I could have said what I meant better: I disagree with the general statement that LodeWallet lacks polish relative to all other light wallets currently included here. It is unclear what limiting principles would exist for such a conversation and how a fair/objective decision would be made. In terms of the description, we're happy to change it. Though, it isn't clear how an 'aim to provide the simplest possible experience' (also subjective, to be fair) is different in kind from some of the existing entries including descriptions like: Cheers |
Hello, regarding "first this and that" there was a long discussion about this here: #167 and an extended discussion here: #176 which ultimately resulted in the rule for adding projects:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description violates the "first this and that rule".: https://developers.cardano.org/docs/portal-contribute#add-a-project-to-showcase
The pull request has not received the required approvals and is closed. However, it can be opened again. Details on: https://developers.cardano.org/docs/portal-contribute/#how-are-pull-requests-reviewed In any case, the discussion can be continued here. |
Checklist
yarn build
after adding my changes without getting any errors.Showcase addition
metadata
nftsupport
wallet