Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LodeWallet to Showcase #915

Closed

Conversation

luigy
Copy link

@luigy luigy commented Jan 5, 2023

Checklist

Showcase addition

  • Title: LodeWallet
  • Description: The functional Cardano wallet. LodeWallet exists to provide the simplest possible experience for Cardano deFi users and a familiar experience for deFi users from other ecosystems. We are the first native Haskell light wallet for Cardano, making direct use of existing open-source Cardano Haskell libraries.
  • Website: https://lodewallet.io/
  • Source: null
  • Tags:
    • metadata
    • nftsupport
    • wallet

@rdlrt
Copy link
Collaborator

rdlrt commented Jan 5, 2023

Reasons for not approving for me:

  • While they might be true, I am not sure if phrases built with haskell or first native Haskell light wallet for Cardano, making direct use of existing open-source Cardano Haskell libraries should be placed in description on showcase, these cannot be verified due to project being closed source. The contributing guidelines certainly ask to stay clear of "first ABC"
  • For a showcase addition - the overall UI feels a bit unpolished than minimalistic (compared to typhon/flint/nami/eternl..), but that might just be me personally.
  • In case it does not get approvals, the wallet is already on support-faq and may also be added to https://essentials.cardano.org instead

@chobbins
Copy link

chobbins commented Jan 6, 2023

Reasons for not approving for me:

  • While they might be true, I am not sure if phrases built with haskell or first native Haskell light wallet for Cardano, making direct use of existing open-source Cardano Haskell libraries should be placed in description on showcase, these cannot be verified due to project being closed source. The contributing guidelines certainly ask to stay clear of "first ABC"

As an alternative for Description, how about:
"Produced by Obsidian Systems, LodeWallet exists to provide the simplest possible experience for Cardano deFi users and a familiar experience for deFi users from other ecosystems."

  • For a showcase addition - the overall UI feels a bit unpolished than minimalistic (compared to typhon/flint/nami/eternl..), but that might just be me personally.

Yes, seems too subjective to block inclusion or warrant further discussion.

Thanks.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get behind it either, mostly because of the reasons @rdlrt already pointed out. If the "simplest possible experience" included anything that the other light wallets had missed, I would happily endorse it: but right now it just provides the same shell as other wallets like Nami but without the breadth of user-demanded features (these tend to be neither superfluous nor distracting).

One feature I'm waiting to see in browser extension wallets is to give users full web pages (like Yoroi has had since the beginning) rather than mobile screens translated into browser popups. The screenshots on the Google Play page tell yet another story of the entire UI being confined by whatever tools & libraries were used to generate the mobile app view. Yes this is the trend in crypto wallets but no I don't have to like it, and objectively this is just another way in which this wallet fails to distinguish itself (and if LodeWallet did provide this feature, I would also be willing to endorse it).

Another reason I'd endorse it (which I don't see in this case) would be a more explicit, verifiable, objective demonstration of how the wallet's "making direct use of existing open-source Cardano Haskell libraries" provides any benefit for the user. Until proven otherwise, this is just an implementation detail & marketing premise which is separate from any aspect of the user experience (if only to inspire the user's confidence... if and only if you can justify why that is so).

@chobbins: Yes, seems too subjective to block inclusion or warrant further discussion.

There is never going to be a case when a reviewer's subjective statement blocks discussion. By the same token, if a reviewer comes forward with a subjective opinion it means they're prepared to justify it according to their understanding of industry best practice & the content guidelines for the Portal. As I see it @rdlrt's statement was an invitation to further discussion rather than a closure, as is my own review... and I'll tag a few more reviewers to ensure this opportunity. 😎

@rphair rphair changed the title Add LodeWallet Showcase Add LodeWallet to Showcase Jan 6, 2023
@rphair rphair added the showcase Indicates a PR/issue on showcase label Jan 6, 2023
@chobbins
Copy link

chobbins commented Jan 6, 2023

@chobbins: Yes, seems too subjective to block inclusion or warrant further discussion.

There is never going to be a case when a reviewer's subjective statement blocks discussion. By the same token, if a reviewer comes forward with a subjective opinion it means they're prepared to justify it according to their understanding of industry best practice & the content guidelines for the Portal. As I see it @rdlrt's statement was an invitation to further discussion rather than a closure, as is my own review... and I'll tag a few more reviewers to ensure this opportunity. 😎

Fair enough! I could have said what I meant better: I disagree with the general statement that LodeWallet lacks polish relative to all other light wallets currently included here. It is unclear what limiting principles would exist for such a conversation and how a fair/objective decision would be made.

In terms of the description, we're happy to change it. Though, it isn't clear how an 'aim to provide the simplest possible experience' (also subjective, to be fair) is different in kind from some of the existing entries including descriptions like:
"Aims to add features most requested by the Cardano community."
"The ultimate wallet experience for the Web, with native NFT and token features, powered by Cardano and third party applications."

Cheers

@katomm
Copy link
Member

katomm commented Aug 1, 2023

Hello, regarding "first this and that" there was a long discussion about this here: #167 and an extended discussion here: #176 which ultimately resulted in the rule for adding projects:

Describe what makes your project special, avoid phrases like "the first this and that". Granular details like which project was first is tribal attribute known to cause rift and conflicts.

Source: Guidelines for adding showcase projects

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description violates the "first this and that rule".: https://developers.cardano.org/docs/portal-contribute#add-a-project-to-showcase

@katomm
Copy link
Member

katomm commented Dec 4, 2023

The pull request has not received the required approvals and is closed. However, it can be opened again. Details on: https://developers.cardano.org/docs/portal-contribute/#how-are-pull-requests-reviewed

In any case, the discussion can be continued here.

@katomm katomm closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Indicates a PR/issue on showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants