New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc changes #7

Closed
wants to merge 20 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@gibix
Contributor

gibix commented May 15, 2018

  • Updated copyright
  • Updated cargo to 0.27 with apis (dropped call to call_main_without_stdin) and new cargo's apis
  • Add quicli to manage cli interafce

gibix added some commits May 15, 2018

update copyright
Signed-off-by: gibix <gibix@riseup.net>
Updated copyright
Updated cargo to 0.27 with apis
Add quicli to manage cli interafce

Signed-off-by: gibix <gibix@riseup.net>
drop 1.27 from travis
Signed-off-by: gibix <gibix@riseup.net>
gitignore .ebuild files
Signed-off-by: gibix <gibix@riseup.net>
add basic test
Signed-off-by: gibix <gibix@riseup.net>
debug test on travis
Signed-off-by: gibix <gibix@riseup.net>
add travis cache
Signed-off-by: gibix <gibix@riseup.net>

@gibix gibix force-pushed the gibix:misc-upgrade branch from 30533b6 to b4388d0 May 15, 2018

first redesign
Signed-off-by: gibix <gibix@riseup.net>

@gibix gibix changed the title from Misc upgrade to misc changes May 15, 2018

gibix added some commits May 16, 2018

add human panic
Signed-off-by: gibix <gibix@riseup.net>
refactor for cli
Signed-off-by: gibix <gibix@riseup.net>
project refactored
Signed-off-by: gibix <gibix@riseup.net>
project refactored
Signed-off-by: gibix <gibix@riseup.net>
@cardoe

Some of the updates look good. Need a few small changes. I'll likely cherry-pick in some commits and let you update from there.

.travis.yml Outdated
@@ -5,7 +5,6 @@ rust:
- nightly
- beta
- stable
- 1.17.0 # minimum supported version (due to unicode-bidi breakage)

This comment has been minimized.

@cardoe

This comment has been minimized.

@gibix

gibix May 16, 2018

Contributor

now 1.17 is nightly

This comment has been minimized.

@cardoe

cardoe May 18, 2018

Owner

No. That's a stable release.

Cargo.toml Outdated
@@ -1,6 +1,6 @@
[package]
name = "cargo-ebuild"
version = "0.1.6-pre"
version = "0.1.7"

This comment has been minimized.

@cardoe

cardoe May 16, 2018

Owner

I use cargo-release so just leave this be.

Cargo.toml Outdated
[badges]
travis-ci = { repository = "cardoe/cargo-ebuild" }
[badges.travis-ci]
repository = "cardoe/cargo-bitbake"

This comment has been minimized.

@cardoe

cardoe May 16, 2018

Owner

This can't be right. I think I have an idea where you copied this from... ;)

This comment has been minimized.

@gibix

gibix May 16, 2018

Contributor

yep

src/main.rs Outdated
.unwrap_or_else(|| String::from(package.name()));
let desc = metadata.description.as_ref().cloned().unwrap();
// TODO: now package.name is InternedString
// .unwrap_or_else(|| String::from(package.name()));

This comment has been minimized.

@cardoe

cardoe May 16, 2018

Owner

Yeah we'll need to resolve this prior to merge.

src/main.rs Outdated
.create(true)
.truncate(true)
.open(&ebuild_path)
.unwrap();

This comment has been minimized.

@cardoe

cardoe May 16, 2018

Owner

I wouldn't want this to panic when you failed to open the file. Returning an error saying it couldn't create the file would be nicer.

src/main.rs Outdated
crates = crates.join(""),
cargo_ebuild_ver = env!("CARGO_PKG_VERSION"),
this_year = 1900 + time::now().tm_year,
).expect("Error during ebuild file writing");

This comment has been minimized.

@cardoe

cardoe May 16, 2018

Owner

Again this is going to panic instead of returning a nice error to the user.

@gibix gibix force-pushed the gibix:misc-upgrade branch from f8b7124 to 06c4a0a May 16, 2018

@gibix

This comment has been minimized.

Contributor

gibix commented May 16, 2018

with the last two commit there is a bit of refactoring and better error handling

gibix added some commits May 16, 2018

add some features from bitbake
Signed-off-by: gibix <gibix@riseup.net>
fix travis badge
Signed-off-by: gibix <gibix@riseup.net>
add some features from bitbake
Signed-off-by: gibix <gibix@riseup.net>
new cli struct and better error
Signed-off-by: gibix <gibix@riseup.net>
add basic git crates support
better errors with failure
better cli
support for env debut
small fix

Signed-off-by: gibix <gibix@riseup.net>
cargo fmt
Signed-off-by: gibix <gibix@riseup.net>

@gibix gibix force-pushed the gibix:misc-upgrade branch from 06c4a0a to 927e686 May 17, 2018

@gibix

This comment has been minimized.

Contributor

gibix commented May 17, 2018

  • add basic git crates support
  • better errors with failure
  • better cli
  • support for env debug
  • small fix
revert travis changes
Signed-off-by: gibix <gibix@riseup.net>
@gibix

This comment has been minimized.

Contributor

gibix commented May 18, 2018

@cardoe nothing will never compile for 1.17. I understand the broken unicode-bidi release but why we need an expicit test on 1.17?

@cardoe

So some of the comment messages are a bit wonky. I think we need to work on cleaning up the history a bit. If you need some help with this ping me on IRC.

e.g a subject of "Update copyright" does the update to cargo 0.27 and then there are commits later on that revert part of those changes that should be squashed together.

@gibix

This comment has been minimized.

Contributor

gibix commented May 22, 2018

This is a single, quite big, refactor change. Me can squash it with a better message and changelog. Something has been rewritten/reverted.

This was referenced May 29, 2018

@gibix gibix closed this Jun 28, 2018

@gibix gibix deleted the gibix:misc-upgrade branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment