Skip to content

Remove collection editor option#5149

Merged
backspace merged 1 commit into
mainfrom
no-collection-edit-cs-11443
Jun 8, 2026
Merged

Remove collection editor option#5149
backspace merged 1 commit into
mainfrom
no-collection-edit-cs-11443

Conversation

@backspace

Copy link
Copy Markdown
Contributor

This reverts #5106, which we decided needs more thorough design so authors of custom collection editors have access to everything the default template does, like permissions, sort handle, deletion button, and the item’s component itself.

This was for #4973, but I’ll use a full custom edit template for realm config instead.

This reverts commit 56405d5f04d83c5f7fcde7ee213cca81f0e3b13c.

The per-usage `edit:` option on field declarations needs a more
thorough design pass — review surfaced several issues with the
shape (collection/wrap contract, attribute forwarding, view-slot
dedup, autosave-on-view) that warrant rethinking the API before
shipping it. Pull it out for now; the consuming branch
(edit-realm-config-cs-10056) is moving back to a `static edit`
on the parent card.
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Host Test Results

    1 files      1 suites   1h 50m 33s ⏱️
2 944 tests 2 929 ✅ 15 💤 0 ❌
2 963 runs  2 948 ✅ 15 💤 0 ❌

Results for commit be379cb.

Realm Server Test Results

    1 files      1 suites   8m 54s ⏱️
1 553 tests 1 553 ✅ 0 💤 0 ❌
1 644 runs  1 644 ✅ 0 💤 0 ❌

Results for commit be379cb.

@backspace backspace marked this pull request as ready for review June 8, 2026 19:30
@backspace backspace requested a review from a team June 8, 2026 20:01
@backspace backspace merged commit 085e5c2 into main Jun 8, 2026
98 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants