Upgrade nodegit to v0.23.0
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
applying the instructions from nodegit/nodegit#853 (comment) (and their current README) seems to have resolved the original issue on CI without any negative effects on CI time. is this sufficient or do we need to test anything else? |
|
The only possible problem I see is that apps may also now need to make the same kind of adjustment you made in travis.yml. I think when we integrate this with the deck app, for example, we will need to update its Dockerfile to add these libraries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is upgrading the
nodegitdependency and "unforks" it. Let's hope this works... 馃