resolve Ember data deprecation for testing tools #741

packages/tools/tests/acceptance/tools-dirtiness-test.js

@@ -0,0 +1,60 @@
+import { module, test } from 'qunit';
+import { setupApplicationTest } from 'ember-qunit';
+import { visit, click, fillIn, waitFor } from '@ember/test-helpers';
+import { login } from '../helpers/login';
+import Service from '@ember/service';
+import { findInputWithValue, findTriggerElementWithLabel } from '../helpers/query-selectors';
+
+
+let StubCardstackDataService = Service.extend({
+  validate() {
+    return Promise.resolve({})
+  },
+  getCardMeta() {
+    return 'Comment #1'
+  },
+  branches() {
+    return []
+  },
+  fetchPermissionsFor() {
+    return Promise.resolve({mayUpdateResource: false, writableFields: ['karmaValue', 'karmaType']})
+  }
+})
+
+module('Acceptance | tools dirtiness', function(hooks) {
+  setupApplicationTest(hooks);
+
+  hooks.beforeEach(function() {
+    delete localStorage['cardstack-tools'];
+    this.owner.register('service:cardstack-data', StubCardstackDataService);
+  });
+
+  hooks.afterEach(function() {
+    delete localStorage['cardstack-tools'];
+  });
+
+  test('track field dirtiness in owned, related records', async function(assert) {
+    await visit('/hub/posts/1');
+    await login();
+    await click('.cardstack-tools-launcher');
+    await waitFor('.cs-active-composition-panel--main');
+    await waitFor('.cs-editor-switch')
+    await click('.cs-editor-switch');
+
+    assert.dom('[data-test-cs-version-control-button-save="true"]').exists('Save button is disabled');
+    assert.dom('[data-test-cs-version-control-button-cancel="true"]').exists('Cancel button is disabled');
+
+    let reviewStatusActionTrigger = findTriggerElementWithLabel.call(this, /Comment #1: Karma/);
+    await click(reviewStatusActionTrigger);
+
+    let karmaInput = findInputWithValue.call(this, '10');
+    await fillIn(karmaInput, '9');
+    assert.dom('[data-test-cs-version-control-button-save="false"]').exists('Save button is enabled');
+    assert.dom('[data-test-cs-version-control-button-cancel="false"]').exists('Cancel button is enabled');
+
+    await fillIn(karmaInput, '10');
+    assert.dom('[data-test-cs-version-control-button-save="true"]').exists('Save button is disabled');
+    assert.dom('[data-test-cs-version-control-button-cancel="true"]').exists('Cancel button is disabled');
+  });
+});
+

packages/tools/tests/acceptance/tools-test.js

@@ -4,6 +4,7 @@ import { visit, click, fillIn, triggerEvent, waitFor, settled } from '@ember/tes
 import { login } from '../helpers/login';
 import { ciSessionId } from '@cardstack/test-support/environment';
 import { hubURL } from '@cardstack/plugin-utils/environment';
+import { findInputWithValue, findTriggerElementWithLabel } from '../helpers/query-selectors';
 
 let nonce = 0;
 
@@ -25,10 +26,6 @@ async function getDocuments(type) {
   return (await response.json()).data;
 }
 
-function findTriggerElementWithLabel(labelRegex) {
-  return [...this.element.querySelectorAll('.cs-toolbox-section label')].find(element => labelRegex.test(element.textContent));
-}
-
 function findAddNewButtonWithLabel(buttonTextRegex) {
   return [...this.element.querySelectorAll('.cs-create-menu ul li')].find(element => buttonTextRegex.test(element.textContent));
 }
@@ -37,11 +34,6 @@ function findSectionLabels(label) {
   return [...this.element.querySelectorAll('.cs-toolbox-section label')].filter(element => label === element.textContent);
 }
 
-function findInputWithValue(value) {
-  return Array.from(this.element.querySelectorAll('input'))
-    .find(element => element.value === value);
-}
-
 module('Acceptance | tools', function(hooks) {
   setupApplicationTest(hooks);
 
@@ -261,30 +253,6 @@ module('Acceptance | tools', function(hooks) {
     assert.dom(reviewStatusInput).isNotDisabled();
   });
 
-  test('track field dirtiness in owned, related records', async function(assert) {
-    await visit('/hub/posts/1');
-    await login();
-    await click('.cardstack-tools-launcher');
-    await waitFor('.cs-active-composition-panel--main');
-    await waitFor('.cs-editor-switch')
-    await click('.cs-editor-switch');
-
-    assert.dom('[data-test-cs-version-control-button-save="true"]').exists('Save button is disabled');
-    assert.dom('[data-test-cs-version-control-button-cancel="true"]').exists('Cancel button is disabled');
-
-    let reviewStatusActionTrigger = findTriggerElementWithLabel.call(this, /Comment #1: Karma/);
-    await click(reviewStatusActionTrigger);
-
-    let karmaInput = findInputWithValue.call(this, '10');
-    await fillIn(karmaInput, '9');
-    assert.dom('[data-test-cs-version-control-button-save="false"]').exists('Save button is enabled');
-    assert.dom('[data-test-cs-version-control-button-cancel="false"]').exists('Cancel button is enabled');
-
-    await fillIn(karmaInput, '10');
-    assert.dom('[data-test-cs-version-control-button-save="true"]').exists('Save button is disabled');
-    assert.dom('[data-test-cs-version-control-button-cancel="true"]').exists('Cancel button is disabled');
-  });
-
   test('allow editing fields of newly added, owned records', async function(assert) {
     await visit('/hub/posts/1');
     await login();

packages/tools/tests/helpers/query-selectors.js

@@ -0,0 +1,14 @@
+
+function findTriggerElementWithLabel(labelRegex) {
+    return [...this.element.querySelectorAll('.cs-toolbox-section label')].find(element => labelRegex.test(element.textContent));
+}
+
+function findInputWithValue(value) {
+    return Array.from(this.element.querySelectorAll('input'))
+        .find(element => element.value === value);
+}
+
+export {
+    findTriggerElementWithLabel,
+    findInputWithValue
+}