New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table columns resize incorrectly when typing Chinese characters #380

Closed
remi-nd opened this Issue May 23, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@remi-nd

remi-nd commented May 23, 2017

Caret is pretty elegant and I love it so much, everything has been working perfectly so far except the auto-resizing of table on typing Chinese.
Here is the context I met,
context
There two problems when typing Chinese in the table:

  • table codes are not aligned correctly.
  • extra characters are appended when tying Chinese within table after Caret auto-generates table snippet. Note that this wired extra string is a recursively cascaded substring of the characters I typed, like 'zhong' => ‘中’, then the extra characters would be 'zhongzhonzhozhz'. However, copy&paste Chinese works fine.

OS: Windows 10
Caret: 2.0.11
Input method: built-in Chinese input method

@astoilkov astoilkov added the bug label May 23, 2017

@pslobo

This comment has been minimized.

Show comment
Hide comment
@pslobo

pslobo May 24, 2017

The second issue seems similar to what is happening in #323

pslobo commented May 24, 2017

The second issue seems similar to what is happening in #323

@YongHee-Kim

This comment has been minimized.

Show comment
Hide comment
@YongHee-Kim

YongHee-Kim Jun 27, 2017

Same with Korean characters too. It seems problem is something to do with double-byte characters.
korean (I was typing "한글")

YongHee-Kim commented Jun 27, 2017

Same with Korean characters too. It seems problem is something to do with double-byte characters.
korean (I was typing "한글")

@massacreformash

This comment has been minimized.

Show comment
Hide comment
@massacreformash

massacreformash Jul 19, 2017

same issue on macOS
when i just typing "表格" in Chinese, i got some extra letters in English that i didn't want.

example

OS: 10.12.5
Caret: 3.2.3
Input method: built-in Chinese input method

massacreformash commented Jul 19, 2017

same issue on macOS
when i just typing "表格" in Chinese, i got some extra letters in English that i didn't want.

example

OS: 10.12.5
Caret: 3.2.3
Input method: built-in Chinese input method

@astoilkov astoilkov added the resolved label Aug 16, 2017

@astoilkov

This comment has been minimized.

Show comment
Hide comment
@astoilkov

astoilkov Jan 11, 2018

Member

The second issue you described is now fixed in the latest Caret 4.0 Beta release available here.

However, the first issue can't be fixed because Chinese characters take more space which makes them impossible to align with the columns that have different than Chinese characters inside of them. If you have suggestions or questions do not hesitate to ask us.

Closing this issue.

Member

astoilkov commented Jan 11, 2018

The second issue you described is now fixed in the latest Caret 4.0 Beta release available here.

However, the first issue can't be fixed because Chinese characters take more space which makes them impossible to align with the columns that have different than Chinese characters inside of them. If you have suggestions or questions do not hesitate to ask us.

Closing this issue.

@astoilkov astoilkov closed this Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment